Fixed a bug in python-iptables #289
Conversation
agent/iptables_helper.py
Outdated
| # The bug is actually fixed in: | ||
| # https://github.com/chruss2/python-iptables/commit/282c790738a111b1ddc27b43ecb0acfab8b09024 | ||
| # and the bugfix is gonna be released in the next (after 0.14.0) release of python-iptables. | ||
| if iptc.version.__version__ <= '0.14.0': |
There was a problem hiding this comment.
This will be True even if _version__ is something like 0.14.0~ds-1 like in Debian bullseye where the bug is not fixed.
There was a problem hiding this comment.
Pls don't mix OS package version with python package version.
There was a problem hiding this comment.
Even so, if we have version like 0.14.0-dev it will be considered "bug-free" even though it's not.
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed in my last commit
|
Please make sure this patch is only applied when iptables version is newer than 1.6.2 (or maybe even 1.7?) |
I believe there'll be no harm in applying it on the system with any iptables version |
Ok, since ldx/python-iptables#299 is merged I believe you're right. |
|
Kudos, SonarCloud Quality Gate passed!
|
Closes #286