This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
Avoid multiple removal of Credentials and Pairing Keys. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-martynovich
changed the title
a-martynovich
force-pushed
the
379-fix-credentials-multiple-removal
branch
from
42b6dca
to
476db1d
Compare
eugenosm
approved these changes
Aug 27, 2019
| @@ -459,12 +459,11 @@ <h6 class="card-subtitle text-muted">View credentials.</h6> | |||
| let data = table.row( $(this).parents('tr') ).data(); | |||
| deleted_pk = data.pk; | |||
|
|
|||
| $('#confirm-btn').on('click', delete_credential ); | |||
| show_confirm_dialog( "Confirm Removal", "Are you sure you want to delete?", "Delete" ); | |||
There was a problem hiding this comment.
The idea was in use one confirmation dialog for several confirmations. And to move it (html dialog template and function) to separate utils file may be.
So, if we plan to move repeated code to somewhere library like in future, may be it would be better to use something like code below or even move it inside a function
$('#confirm-btn').off('click');
$('#confirm-btn').on('click', delete_credential );
show_confirm_dialog( "Confirm Removal", "Are you sure you want to delete?", "Delete" );If not, then your variant is fine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379 and part of #380.