-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Errno 2] No such file or directory: 'grub-install': 'grub-install' #15
Comments
Hi, sorry for that delay in response, also thank you for providing solution! I will test it and push the fix. |
|
I don't think that this is an issue here, from quick googling it turns out that pop doesn't use grub so it makes sense that it will be missing. @RUvlad1 Can you try to install grub package and try again? If it would work, can you post what package it was? |
Issue Reproduce Instructions
Expected Behavior
Current Behavior
Info of My Environment
WoeUSB Version
WoeUSB Source
Information about the Operating System
Information about the Source Media
Information about the Target Device
Debugging
In the test environment(Centos7.6), there is no command named 'grub-install', 'grub2-install' exists.
I go through the source code and find where it happens. It happened in function 'check_runtime_dependencies' in file WoeUSB/utils.py, where called shutil.which() to judge which command to use.
It's the if clause matter. when a command, say, 'grub-install' does not exists, shutil.which() returns None instead of ''.
I tested shutil.which() in python3 interpreter.
It's a convention to write such kind of if clause as follows
or
The text was updated successfully, but these errors were encountered: