Score updates #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck in YambViewController
martinpesevski
requested changes
Oct 10, 2022
Yamb/YambDataSource.swift
Outdated
| var tmp = 0 | ||
| if let field = fieldsDict[indexPath.section]?[indexPath.item] { | ||
| if (field.score != nil) { | ||
| tmp = field.score! |
There was a problem hiding this comment.
never force unwrap! Use if let fieldScore = field.score {
Yamb/YambDataSource.swift
Outdated
| @@ -198,7 +220,8 @@ class YambDataSource { | |||
| } | |||
|
|
|||
| func clear(indexPath: IndexPath) { | |||
| if let field = fieldsDict[indexPath.section]?[indexPath.item] { | |||
| if let field = fieldsDict[indexPath.section]?[indexPath.row] { | |||
There was a problem hiding this comment.
why did you switch to .row?
There was a problem hiding this comment.
I wasn't sure what the difference was between .item and .row and was testing out, I changed it back to .item
Yamb/YambViewController.swift
Outdated
| return stackView | ||
| }() | ||
|
|
||
| lazy var button: UIButton = { | ||
| lazy var NewGameButton: UIButton = { |
There was a problem hiding this comment.
names start with non-capital letter
Yamb/YambDataSource.swift
Outdated
| @@ -79,11 +79,17 @@ class YambDataSource { | |||
| return [0:topFields, 1:middleFields, 2:bottomFields] | |||
| }() | |||
|
|
|||
| var totalScore: Int { | |||
| lazy var totalScore: Int = { | |||
There was a problem hiding this comment.
lazy var initializers are only called once. this should be a computed property. it is enough to say
var totalScore: Int = { getTotalScore() }
Yamb/YambViewController.swift
Outdated
| //self.navigationController?.navigationBar.isHidden = true | ||
|
|
||
| } | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.