avoid 404 error when clicking on country database #44
Conversation
There was a problem hiding this comment.
Hi @licataae thank you for the PR!
The escape is a great idea, it should work much better.
I believe we could take another approach: change the map interaction to open directly the correct URL: /repo/?s=Canada . WYT? We may have other places that it occurs:
https://github.com/WomenInNeuroscience/winrepo/blob/main/profiles/templates/profiles/home.html
https://github.com/WomenInNeuroscience/winrepo/blob/main/profiles/static/profiles/js/home-graphs.js#L99
|
Hi @anibalsolon, thank you for this information & for your reply! I'm not sure I understand your suggested approach / the file where we should alter the map interaction. Do you suggest modifying the DrawMap function in home-graphs.js to directly call on the correct URL? e.g., line 99 of home-graphs.js: window.location.href = '/list?s=' + encodeURIComponent(country) ? Thank you very much! |
|
@licataae yes, I suggest changing these 4 lines to point to the correct URL, instead of this line is for when you click on the map: these lines are for the links in these pie plots: https://github.com/WomenInNeuroscience/winrepo/blob/main/profiles/templates/profiles/home.html#L197 |
licataae
force-pushed
the
development_branch
branch
from
d5c396f
to
e3895ca
Compare
|
Ah, got it! I just updated these two files & tested it out, now the map & profiles load the URL directly... I force pushed the new commit instead of the old (let me know if there's a smoother way to go about this). Thanks! |
When someone would click on countries in the interactive world map on the homepage, a 404 error would occur - I added an explicit path for the profiles list & used re.escape instead of compile to escape special characters in search terms for regex matching. I tested the changes on a local deployment using 100, 500 and 1000 profiles and it worked just fine, but let me know if I can test anything else out to be sure. Thanks!