Remove the white space above the footer.

[aezazs-multidots]

I have removed the white space at the bottom of the footer.

Below is a screenshot.

Closes #665

[jonathanbossenger]

Hi @aezazs-multidots thanks for this PR

Ideally, we should be careful of removing functionality from the templates that manage pages. In this case, the PR will remove the Edit link that will appear at the bottom of the page for logged-in users.

In this case, what might be better is if you consider the styling for the entry-footer class, and look at what would happen if we adjust or remove the padding for that class.

We would also need to make sure the change doesn't affect other pages on the site negatively.

[aezazs-multidots]

Hello @jonathanbossenger

I have made the changes as you told me and committed the code.

Thanks

[courtneyr-dev]

Have we checked with manually editing the page in block editor before modifying theme code? Theme redesign will be shipping in the near future, so these changes will need to be reviewed again then.

[jonathanbossenger]

@aezazs-multidots thanks for the refresh.

I notice that the wp-content/themes/pub/wporg-learn-2020/css/style-rtl.css and wp-content/themes/pub/wporg-learn-2020/css/style.css files now have conflicts with the base branch, which I think is because they are rebuilt every time the yarn build process is run.

@adamwoodnz are you able to confirm my assumptions above? Is this something we should expect, or is there a way to prevent these conflicts?