PHPCS 3.4.0: Add new Generic.WhiteSpace.IncrementDecrementSpacing sniff

[jrfnl]

Rationale

Ever come across code like this: $a + - $b ++ ?

Let's at least make the confusion slightly less by prohibiting spaces between a variable and the incrementor/decrementor.

PHPCS 3.4.0 introduces a new Generic.WhiteSpace.IncrementDecrementSpacing sniff which does just that, including auto-fixer.

I ran that sniff over WP Core when I originally wrote the sniff and at that time, WP Core basically complied with the "no space between incrementor/decrementor and variable" rule, except for 5 instances, which can be auto-fixed by this sniff anyway.

I'd like to suggest adding this sniff to the Core ruleset once the minimum PHPCS requirement has been upped to PHPCS 3.4.0.

/cc @pento

References

• Upstream issue: Feature suggestion: sniff to check whitespace around incrementors/decrementors squizlabs/PHP_CodeSniffer#2172
• Upstream (merged) PR: New Generic.WhiteSpace.IncrementDecrementSpacing sniff squizlabs/PHP_CodeSniffer#2174

Action Checklist

Once PHPCS 3.4.0 has been released and WPCS is ready/willing to up the minimum required PHPCS version:

• Update the PHPCS version requirements in the composer.json file.
• Update references to the WPCS minimum PHPCS version requirements in the Readme and wherever else needed.
• Add the Generic.WhiteSpace.IncrementDecrementSpacing sniff to the WordPress-Core ruleset.xml file (in the bottom section/uncovered by handbook).