New Generic.WhiteSpace.IncrementDecrementSpacing sniff #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New sniff to check that there are no spaces (or comments) between an incrementor/decrementor and the variable it applies to. The sniff can examine both PHP as well as JS files for this, though I suspect there may be some false positive reports for JS at some point as `T_STRING` is quite a generic token to check for. Includes unit tests. Includes auto-fixer. Includes code-consistency metrics. I've made a conscious decision to not make the number of spaces accepted between the in/decrementor and the variable configurable as it is a widely accepted convention that there should be no spaces between them. If it would be so desired, I can add a public property to make this configurable. Fixes 2172
|
This sniff should probably be added to the PSR12 ruleset (in due time) as - in part inspired by this sniff -, a rule to that effect has now been added to the draft PSR12: php-fig/fig-standards#1089 |
gsherwood
added a commit
that referenced
this pull request
Oct 23, 2018
|
Thanks a lot for this. I've added it to the Squiz and PHPCS standards as well. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New sniff to check that there are no spaces (or comments) between an incrementor/decrementor and the variable it applies to.
The sniff can examine both PHP as well as JS files for this, though I suspect there may be some false positive reports for JS at some point as
T_STRINGis quite a generic token to check for.Includes unit tests.
Includes auto-fixer.
Includes code-consistency metrics.
I've made a conscious decision to not make the number of spaces accepted between the in/decrementor and the variable configurable as it is a widely accepted convention that there should be no spaces between them.
If it would be so desired, I can add a public property to make this configurable.
Fixes #2172