Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Sniff to check that slashed data is passed to functions that expect it #1222

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from
Draft

WIP: Sniff to check that slashed data is passed to functions that expect it #1222

wants to merge 21 commits into from

Commits on Oct 31, 2017

  1. WIP: Enforce wp_slash() on functions that expect slashed data

    @JDGrimes
    JDGrimes committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    70de681 View commit details
    Browse the repository at this point in the history

  2. Detect superglobals and don't require slashing

    @JDGrimes
    JDGrimes committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    832fc48 View commit details
    Browse the repository at this point in the history

  3. Don't expect whitespace

    @JDGrimes
    JDGrimes committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    728419a View commit details
    Browse the repository at this point in the history

  4. Add a couple of filters that expect slashed args

    @JDGrimes
    JDGrimes committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    dc7310f View commit details
    Browse the repository at this point in the history

  5. Give warnings instead of errors when inside a slashed function

    @JDGrimes
    JDGrimes committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    290f96a View commit details
    Browse the repository at this point in the history

  6. Add more functions to lists

    @JDGrimes
    JDGrimes committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    ad47439 View commit details
    Browse the repository at this point in the history

  7. Move, rename, and alphabetize the list of filters

    @JDGrimes
    JDGrimes committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    75c68d2 View commit details
    Browse the repository at this point in the history

  8. Remove commented out code

    @JDGrimes
    JDGrimes committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    3004d53 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2017

  1. Warn about slashable static strings, and improve array value checks

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    4f30543 View commit details
    Browse the repository at this point in the history

  2. Add another function

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    e454418 View commit details
    Browse the repository at this point in the history

  3. Don't assume whitespace for get_term_by()

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    3318f31 View commit details
    Browse the repository at this point in the history

  4. Add more functions

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    f9192a6 View commit details
    Browse the repository at this point in the history

  5. Better handling of partly-slashed functions when not arrays

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    a4162b3 View commit details
    Browse the repository at this point in the history

  6. Add another function

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    49b33ee View commit details
    Browse the repository at this point in the history

  7. Always include found value in error messages

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    0655848 View commit details
    Browse the repository at this point in the history

  8. Add more functions

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    c32a653 View commit details
    Browse the repository at this point in the history

  9. Give a warning when the key is not a string

    @JDGrimes
    JDGrimes committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    2c18b12 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2017

  1. Update function lists

    @JDGrimes
    JDGrimes committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    79900c6 View commit details
    Browse the repository at this point in the history

  2. Use a different error code when inside slashed function definitions

    @JDGrimes
    JDGrimes committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    3eed1f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2017

  1. Only warn about strings that contain slashes (not just quotes)

    @JDGrimes
    JDGrimes committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    fa5d2c2 View commit details
    Browse the repository at this point in the history

  2. Fix PHPCS errors

    @JDGrimes
    JDGrimes committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    f321bed View commit details
    Browse the repository at this point in the history