Skip to content

Commit

Permalink
Fix cover block placeholder background color (#12187)
Browse files Browse the repository at this point in the history
Prevent the `components` package styles from overriding the cover block background color.

Fixes #12179.
Related: [Trac-45279](https://core.trac.wordpress.org/ticket/45279).

For details on how to reproduce the issue, see #12179.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- ~[ ] My code follows the accessibility standards.~ <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- ~[ ] My code has proper inline documentation.~ <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
  • Loading branch information
desrosj authored and jorgefilipecosta committed Nov 21, 2018
1 parent 36acf7d commit 43bb1ed
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion packages/block-library/src/cover/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,13 @@
}

&.components-placeholder {
height: inherit;
// use opacity to work in various editor styles
background: $dark-opacity-light-200;
min-height: 200px;

.is-dark-theme & {
background: $light-opacity-light-200;
}
}

// Apply max-width to floated items that have no intrinsic width
Expand Down

0 comments on commit 43bb1ed

Please sign in to comment.