Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Block: add caption support #11589

Closed
fienen opened this issue Nov 7, 2018 · 1 comment · Fixed by #15554
Closed

Table Block: add caption support #11589

fienen opened this issue Nov 7, 2018 · 1 comment · Fixed by #15554

Comments

@fienen
Copy link

@fienen fienen commented Nov 7, 2018

Describe the bug
When creating a table block, you have to manually edit the HTML if you want to include a caption on the table. A <caption> is allowed to be the first child of a <table> element for accessibility purposes as described in https://www.w3.org/WAI/tutorials/tables/caption-summary/ and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/caption

To Reproduce
Steps to reproduce the behavior:

  1. Create or edit a post
  2. Insert a table block
  3. Convert to HTML editing
  4. Add a <caption> element just inside the <table> element
  5. Convert back to visual editing

Expected behavior
This should not produce an error, and should be treated as acceptable markup. Bonus points if the table block editor straight up supported captions, as well as thead/tfoot without having to manually editing the HTML of the table.

Screenshots
table1
table2

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 70

Additional context

  • Gutenberg 4.2.0
@ellatrix ellatrix changed the title Table Block editor treats captions as invalid markup Table Block: add caption support Jun 24, 2019
@ellatrix

This comment has been minimized.

Copy link
Member

@ellatrix ellatrix commented Jun 24, 2019

Right, there is currently no caption support.

@talldan talldan mentioned this issue Jul 19, 2019
5 of 5 tasks complete
@talldan talldan self-assigned this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.