Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classic Block has broken block switcher #16137

Closed
melchoyce opened this issue Jun 12, 2019 · 3 comments · Fixed by #17323
Closed

Classic Block has broken block switcher #16137

melchoyce opened this issue Jun 12, 2019 · 3 comments · Fixed by #17323
Assignees
@talldan
Labels
[Block] Classic Affects the Classic Editor Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@melchoyce
Copy link
Contributor

Describe the bug
The Classic Block seems to have picked up a block switcher, perhaps after the group block was merged?

To reproduce
Steps to reproduce the behavior:

  1. Fire up the latest version of master (5.9.0-rc.1)
  2. Add a Classic Block to your editor
  3. See the block switcher in the top right corner when the block is selected

Expected behavior
There is no block switcher, it should look like this:

image

Screenshots

classic-block
@melchoyce melchoyce added the [Block] Classic Affects the Classic Editor Block label Jun 12, 2019
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Aug 22, 2019
@youknowriad
Copy link
Contributor

This is a very annoying bug could we try to fix it? Maybe we could just disable the block switcher (group transform) from the classic block. cc @getdave

@donmhico
Copy link
Contributor

Hello @youknowriad @melchoyce

I would like to try and give this a fix, however I have a question as I want to understand more. Is there any reason why we want to disable block switcher (group transform) icon in Classic Block Editor? Is this because other than "Group" there's no other transform option?

@talldan
Copy link
Contributor

talldan commented Sep 4, 2019

I've updated the styling in #17323, but I didn't really consider that it should have no transform 🤔

@talldan talldan mentioned this issue Sep 4, 2019
Merged
5 tasks
@talldan talldan self-assigned this Sep 5, 2019
@talldan talldan added the [Status] In Progress Tracking issues with work in progress label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Block] Classic Affects the Classic Editor Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix styling of classic block's block controls WordPress/gutenberg
4 participants
@youknowriad @talldan @melchoyce @donmhico