Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra css class for a column block is not being applied inside the editor. #17049

Closed
Levdbas opened this issue Aug 15, 2019 · 2 comments · Fixed by #17422
Closed

Extra css class for a column block is not being applied inside the editor. #17049

Levdbas opened this issue Aug 15, 2019 · 2 comments · Fixed by #17422
Labels
[Block] Columns Affects the Columns Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@Levdbas
Copy link

Levdbas commented Aug 15, 2019

Describe the bug
Extra css classes for a single block column are not being applied in the editor.

To reproduce
Steps to reproduce the behavior:

  1. Place columns block in the editor
  2. Select one of the columns
  3. In the right sidebar, under advanced, give the column an extra css class
  4. The classname just entered is not being added to the column html element inside the editor while is being added on the front-end after save.

Expected behavior
The extra classname for the column block would be added to the column block as well inside the editor and not only on the front-end.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Firefox
  • Version 68.02

Additional context

  • Used under Gutenberg plugin version 6.3
@youknowriad youknowriad added [Block] Columns Affects the Columns Block [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Aug 16, 2019
@HardeepAsrani
Copy link
Contributor

It was also reported by one of our users. I've sent a PR which fixes it. :)

@munirkamal
Copy link
Contributor

I can also confirm this bug. I am really hoping this gets fixed as this way we can apply CSS classes to individual columns and style them accordingly. This should be labeled as a "Bug" and not as "Enhancemenet" in my view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants