-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported Hulu embed block #23920
Comments
Possibly. I tried testing using the link from that WordPress.com article (https://www.hulu.com/watch/771496), but I'm in Australia, so this would also be an issue for me. Would be great if someone US based could test this. |
@talldan Video: https://recordit.co/WEbLy3XdnR (nothing No error message in the console. @tacitonic you wrote "The console shows that there might be an API fetch error." - Would you mind testing it again and share the API error? It might help to track this down. OS X 10.14.6 |
Unless I'm mistaken this is the direct link to hulu's oembed provider https://www.hulu.com/api/oembed.xml?url=https://www.hulu.com/watch/771496 but as you can see it's not working. I wonder if they silently removed their oembed API? |
Thanks for scouting this out, @youknowriad |
yes, if it's confirmed we'd need to remove both the block and the provider from core too. I'd love for someone else (preferably in the US) to try to confirm that. |
@youknowriad I can confirm "We'll be back - This page is temporarily unavailable. Please try refreshing the page or go back to the homepage." That this is not working from the US either. Just pinged them on Twitter. But I doubt I'll get an answer. |
This was the answer: "Apologies for any disappointment! This isn't an available option at the moment, but we'll express your interest. (...)" Sounds quite noncomittal. It seems to be ok to remove the Hulu block from the block editor. @youknowriad |
Thanks so much for testing @bph! Looks like the previous approach has been to remove unsupported embed blocks - #12759, and then as Riad mentions, also remove the provider code from core - https://core.trac.wordpress.org/ticket/45399. I've updated this issue and made a new trac ticket for the core task: |
I'm new to core, but perhaps I could have a go at this? The task seems simple enough; just have to remove |
Hey @tacitonic! Thanks for stepping in 👍 |
Sounds great, thanks @tacitonic! |
Closed by #23984. |
Just wanted to add this for reference. The Hulu support team responded saying it was not a supported option at this time: https://twitter.com/hulu_support/status/1283562756726300672 |
Describe the bug
The Hulu Embed Block from the default Block Editor cannot embed any links. This error was discovered while creating the Documentation for this block. Different links were tried from Hulu as well as this article - https://wordpress.com/support/videos/hulu/ but none of them successfully embedded the content. There might be a possibility of non-subscribers/paywall or geo-locking preventing the embed.
The console shows that there might be an API fetch error.
CC: @bph
To reproduce
Steps to reproduce the behavior:
Expected behavior
The Hulu link gets embedded.
Editor version:
Desktop:
The text was updated successfully, but these errors were encountered: