Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported Hulu embed block #23920

Closed
tacitonic opened this issue Jul 14, 2020 · 14 comments · Fixed by #23984
Closed

Remove unsupported Hulu embed block #23920

tacitonic opened this issue Jul 14, 2020 · 14 comments · Fixed by #23984
Assignees
Labels
[Block] Embed Affects the Embed Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@tacitonic
Copy link
Member

tacitonic commented Jul 14, 2020

Describe the bug

The Hulu Embed Block from the default Block Editor cannot embed any links. This error was discovered while creating the Documentation for this block. Different links were tried from Hulu as well as this article - https://wordpress.com/support/videos/hulu/ but none of them successfully embedded the content. There might be a possibility of non-subscribers/paywall or geo-locking preventing the embed.
The console shows that there might be an API fetch error.

CC: @bph

To reproduce
Steps to reproduce the behavior:

  1. Add a Hulu Embed Block
  2. Paste a Hulu link in the text box.
  3. Click "Embed"
  4. The block will display an error similar to this: https://i1.wp.com/wordpress.org/support/files/2020/06/soundcloud5.4_8.png?w=700&ssl=1

Expected behavior
The Hulu link gets embedded.

Editor version:

  • WordPress version: 5.4.2
  • Default Block Editor

Desktop:

  • OS: Ubuntu 20.04
  • Browser: Chrome
  • Version: 83.0.4103.116
@tacitonic tacitonic changed the title Link Embedding for Hulu Embed Block doesn't work Hulu Embed Block doesn't embed links Jul 14, 2020
@talldan talldan added [Block] Embed Affects the Embed Block [Status] Needs More Info Follow-up required in order to be actionable. Needs Testing Needs further testing to be confirmed. and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Jul 14, 2020
@talldan
Copy link
Contributor

talldan commented Jul 14, 2020

There might be a possibility of non-subscribers/paywall or geo-locking preventing the embed.

Possibly. I tried testing using the link from that WordPress.com article (https://www.hulu.com/watch/771496), but I'm in Australia, so this would also be an issue for me. Would be great if someone US based could test this.

@bph
Copy link
Contributor

bph commented Jul 14, 2020

@talldan
It doesn't work for me in US (Florida) either.

Video: https://recordit.co/WEbLy3XdnR (nothing

No error message in the console.

@tacitonic you wrote "The console shows that there might be an API fetch error." - Would you mind testing it again and share the API error? It might help to track this down.

OS X 10.14.6
Chrome: Version 83.0.4103.116
Gutenberg 8.5.1
WP 5.4.2

@tacitonic
Copy link
Member Author

Screenshot (132)

@youknowriad
Copy link
Contributor

Unless I'm mistaken this is the direct link to hulu's oembed provider

https://www.hulu.com/api/oembed.xml?url=https://www.hulu.com/watch/771496

but as you can see it's not working. I wonder if they silently removed their oembed API?

@bph
Copy link
Contributor

bph commented Jul 15, 2020

Thanks for scouting this out, @youknowriad
As it seems to be an abandoned service, shouldn't we remove the embed block from the block editor? Or at least add a note to the block, that it might not work and decide on a grace period after which we would remove it with unchanged status.

@youknowriad
Copy link
Contributor

yes, if it's confirmed we'd need to remove both the block and the provider from core too. I'd love for someone else (preferably in the US) to try to confirm that.

@bph
Copy link
Contributor

bph commented Jul 15, 2020

@youknowriad I can confirm "We'll be back - This page is temporarily unavailable. Please try refreshing the page or go back to the homepage." That this is not working from the US either. Just pinged them on Twitter. But I doubt I'll get an answer.

@bph
Copy link
Contributor

bph commented Jul 16, 2020

This was the answer: "Apologies for any disappointment! This isn't an available option at the moment, but we'll express your interest. (...)"

Sounds quite noncomittal. It seems to be ok to remove the Hulu block from the block editor. @youknowriad

@talldan talldan changed the title Hulu Embed Block doesn't embed links Remove unsupported Hulu embed block Jul 16, 2020
@talldan talldan added [Type] Task Issues or PRs that have been broken down into an individual action to take Good First Issue An issue that's suitable for someone looking to contribute for the first time and removed Needs Testing Needs further testing to be confirmed. labels Jul 16, 2020
@talldan
Copy link
Contributor

talldan commented Jul 16, 2020

Thanks so much for testing @bph!

Looks like the previous approach has been to remove unsupported embed blocks - #12759, and then as Riad mentions, also remove the provider code from core - https://core.trac.wordpress.org/ticket/45399.

I've updated this issue and made a new trac ticket for the core task:
https://core.trac.wordpress.org/ticket/50676#ticket

@tacitonic
Copy link
Member Author

I'm new to core, but perhaps I could have a go at this? The task seems simple enough; just have to remove core-embed/hulu from packages/block-library/src/embed/core-embeds.js & then also make the required changes to src/wp-includes/class-oembed.php.
Kindly mention if I missed anything. Could you assign me to this issue @talldan?

@ntsekouras
Copy link
Contributor

Hey @tacitonic! Thanks for stepping in 👍

@talldan
Copy link
Contributor

talldan commented Jul 16, 2020

Sounds great, thanks @tacitonic!

@talldan
Copy link
Contributor

talldan commented Jul 16, 2020

Closed by #23984.

@desrosj
Copy link
Contributor

desrosj commented Jul 20, 2020

Just wanted to add this for reference. The Hulu support team responded saying it was not a supported option at this time: https://twitter.com/hulu_support/status/1283562756726300672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
6 participants