Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkControl: screen jumps when you click on the search result to select the #28373

Open
Tracked by #35073
desaiuditd opened this issue Jan 21, 2021 · 2 comments
Open
Tracked by #35073
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended

Comments

@desaiuditd
Copy link
Member

Description

When adding a link in the paragraph block, if the paragraph is long and does not fit in the current viewport, and if the user clicks on the search result to add the link, the screen jumps. It's a little annoying experience.

Step-by-step reproduction instructions

  • Create a new post in Gutenberg block editor.
  • Add a paragraph block and adds a very long text in one single paragraph block such that the paragraph block length goes beyong the viewport.
  • Press CMD + K or click on Link format icon from the block toolbar to add the link.
  • Type some search keywords.
  • Click on any of the search result.
  • Observe the screen jump after you click.

Expected behaviour

The screen should not jump at the top of the paragraph block after user adds the link by clicking on the search result from mouse.

Actual behaviour

The screen jumps at the top of the paragraph block after user adds the link by clicking on the search result from mouse.

If the paragraph is small and fits in the current viewport, the jump doesn't happen. Screen stays as is.

If the user uses keyboard up/down keys to select the search results and add the link, the jump doesn't happen. Screen stays as is.

Jump happens only when user uses mouse and clicks on search result, to add the link.

Screenshots or screen recording (optional)

Jump happens when using mouse click.

2021-01-21 12 09 01

Jump doesn't happen when small paragraph which fits into viewport.

2021-01-21 12 09 40

Jump doesn't happen when using keyboard up/down keys.

2021-01-21 12 15 03
2021-01-21 12 15 40

WordPress information

  • WordPress version: 5.6
  • Gutenberg version: 9.8.0
  • Are all plugins except Gutenberg deactivated? Yes.
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes. Twenty Twenty

Device information

  • Device: MacBook Pro (16-inch, 2019)
  • Operating system: macOS 10.15.7 (19H114) Catalina
  • Browser: Chrome Version 88.0.4324.96 (Official Build) (x86_64)
@desaiuditd desaiuditd added [Type] Bug An existing feature does not function as intended [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jan 21, 2021
@desaiuditd desaiuditd added the Needs Testing Needs further testing to be confirmed. label Feb 2, 2021
@skorasaurus
Copy link
Member

Thanks for reporting; I was unable to reproduce this in either firefox and chrome; using the newest build of Gutenberg from yesterday (built directly from the source).

(a wild guess in case, I tried this with both spotlight mode on and the top toolbar off; and spotlightmode off and top toolbar off as well).

Could you try to reproduce this in a newer version of Gutenberg? (You can download a nightly release that's built from the code at https://gutenbergtimes.com/need-a-zip-from-master/#nightly )

@chaion07 chaion07 removed the Needs Testing Needs further testing to be confirmed. label Apr 27, 2021
@chaion07
Copy link

First of all, kudos to @desaiuditd for nicely documenting this. We discussed this issue in a recent triage session and a few of us were able to reproduce it in Chrome and Brave browsers respectively. Thus I have removed the 'Needs Testing' label as advised by the team. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants