Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview: Inline image improvements #28813

Open
paaljoachim opened this issue Feb 7, 2021 · 6 comments
Open

Overview: Inline image improvements #28813

paaljoachim opened this issue Feb 7, 2021 · 6 comments
Labels
[Block] Image Affects the Image Block Needs Design Needs design efforts. [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 7, 2021

What problem does this address?

EDITING this issue to focus on various Inline image issues.

It is very limited in how we can control the Inline Image.
Here is an example of what it currently looks like.

Screen Shot 2021-02-07 at 14 23 58

What is your proposed solution?

As @melchoyce mentioned in this comment:
#19426 (comment)
"It might make more sense to refactor inline images to be child blocks, so they can have their own toolbar for settings. That would help eliminate this one-off UI and make the block's behavior more consistent."
Based on Mathias comment below. We need to instead create a custom UI for the inline image feature.

Overview of Inline Image issues:

An example would be to control the height as mentioned in this issue.
#18035

Improve inline image sizing
#19426

Inline Images: Can't replace image
#25909

Inline images shows as Unattached in the media library
#17658

Inline linked image: inline popovers overlap and can hardly be used
#15761

Inline Images no longer show handles when selected
#15083

Inline images can't be resized using only the keyboard
#10595

How to create a custom inline-block?
#10235

It was brought up during a design triage on Slack:
https://wordpress.slack.com/archives/C02S78ZAL/p1612282641102200

@paaljoachim paaljoachim added [Block] Image Affects the Image Block [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. labels Feb 7, 2021
@mtias
Copy link
Member

mtias commented Feb 23, 2021

It's not possible to use child blocks for inline images. Blocks are block elements, not inline formatting. Improvements to inline images UI should be proposed separately and need custom UI.

@mtias mtias removed the [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P label Feb 23, 2021
@paaljoachim
Copy link
Contributor Author

I can edit this issue to become an inline image tracking issue instead. Then I will look at creating a custom UI issue for the inline images.

@paaljoachim paaljoachim changed the title Create inner/child block for the Inline Image + added various Inline Image issues. Overview: Inline image improvements Feb 23, 2021
@mtias
Copy link
Member

mtias commented Feb 23, 2021

Yes, the width in particular is quite confusing.

@XVII
Copy link

XVII commented Feb 17, 2023

An additional item for your inline image megathread: #48150

@westonruter
Copy link
Member

Another inline image issue, this time from Trac: Core-59352 "Inline images inserted in the block editor can erroneously get fetchpriority=high". Also mentioned there is the incorrect width and height are added by wp_img_tag_add_width_and_height_attr(), resulting in wp_img_tag_add_srcset_and_sizes_attr() adding the wrong sizes which finally results in an oversized image being served.

@mrwweb
Copy link

mrwweb commented Jul 9, 2024

#63323: "No ability to edit inline image alt text in context"

@paaljoachim paaljoachim added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block Needs Design Needs design efforts. [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

6 participants