Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android blocker inserter entrance animation occasionally jumps to middle of screen #32012

Open
dcalhoun opened this issue May 19, 2021 · 4 comments
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@dcalhoun
Copy link
Member

Description

When opening the block inserter on Android, the animation often flashes the blocker inserter UI onto the screen before subsequently hiding it and animating upwards into place. Occasionally, the block inserter will even render detached from the bottom of the screen, leaving it floating in the middle of the screen before animating downward into place.

The issue is fairly sporadic and difficult to reproduce consistently, at least the detached block inserter occurrence. It has been reproduced in the WPAndroid 17.3 beta build. It was not reproducible in the WPAndroid 17.2 Play Store build.

Step-by-step reproduction instructions

  1. Launch the Gutenberg block editor in the WPAndroid app.
  2. Tap the plus icon button to open the block inserter.
  3. Close the block inserter.
  4. Repeat the previous steps multiple times over.

Expected behaviour

The block inserter always animates into place sliding upwards.

Actual behaviour

The block inserter often flashes on the screen before animating. Occasionally animates downwards to the bottom of the screen.

Screenshots or screen recording (optional)

Screenshot of detached block inserter android-block-inserter-detached
17.3 beta recording with jumping animation (occurs on 4th and final attempt)
android-block-inserter-jump.mp4
17.2 recording without jumping animation
android-block-inserter-no-jump.mp4

WordPress information

  • WordPress version: 5.6.0
  • Gutenberg version: 10.5.4
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: Samsung Galaxy S20
  • Operating system: Android 11
  • WordPress app version: 17.3
@dcalhoun dcalhoun added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label May 19, 2021
@dcalhoun
Copy link
Member Author

From reviewing the 1.53 release changes, it appears a few changes (#30291, #31655, #28495) were made to the block inserter. At this time, I am unsure if any of them are directly related. The next best step might be to individually revert each change to identify where the issue may have originated.

@fluiddot
Copy link
Contributor

That's interesting, as you pointed, most likely this was introduced on those PRs. I'll try to spare some time to investigate this further, thanks for opening the issue 🙇 !

@jordesign
Copy link
Contributor

@dcalhoun Just looping through some older issues and wanted to check if this bug is still relevant?

@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Aug 17, 2023
@dcalhoun
Copy link
Member Author

@jordesign yes, this bug is still present. It is less noticeable and occurs in a slightly different manner now that the inserter is full screen height on Android only (#34129), but it the issue remains.

We can keep this open or close it and consider this one of many performance/animation issues to resolve in #37559. Either approach is valid in my opinion. I updated #37559 to reference this issue for posterity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants