Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series of bugs and shortcomings faced during 5.9 go/no go prep #35662

Closed
11 of 16 tasks
mtias opened this issue Oct 15, 2021 · 11 comments
Closed
11 of 16 tasks

Series of bugs and shortcomings faced during 5.9 go/no go prep #35662

mtias opened this issue Oct 15, 2021 · 11 comments
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@mtias
Copy link
Member

mtias commented Oct 15, 2021

Compiling a list of bugs, shortcomings, and enhancement ideas I run into when preparing for the go / no go demo.

There's a lot of small issues related to the roundtrip a ServerRender block needs to do for any change and a great showcase for why they should be avoided entirely for any interactive block.

Screeny.Video.14.Oct.2021.at.12.29.46.mov
Screeny.Video.14.Oct.2021.at.18.41.39.mov
  • Navigation block new link would break with no visible signs of recovery — typing the name of the page would not bring the page up.

Generally can happen after leaving the page open for a little bit or interacting for a while. It's understandable connection might break, but there should be some feedback.

Screeny.Video.13.Oct.2021.at.20.28.05.mov

image

  • Buttons inside groups are misaligned. (Might be theme related.)

image

  • Disabling theme editor styles in preferences makes some elements in the page load with default colors and not the current color scheme.

image

  • The sibling inserter repositioning, together with the animation, makes it jump around.
Screeny.Video.14.Oct.2021.at.18.31.43.mov

  • The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

image

  • There's also a weird dotted outline on the site block.

image

  • More blocks with dotted outlines that don't seem appropriate.

image

  • Search in navigation menus is super awkward. It should be possible to get an icon only button that expands inline or in an overlay. This should likely also be the default. The initial insertion state, in particular, is a terrible experience (Search: Hide label when inserted in Navigation block #36026):

image

  • Menu settings (called Display) should come before the Typography supports and should probably not be in a panel at all (not collapsible).

  • Typography: default size looks "unset".

image

@mtias mtias added the [Type] Bug An existing feature does not function as intended label Oct 15, 2021
@MaggieCabrera
Copy link
Contributor

There's also a weird dotted outline on the site block.

I suspect that is a Videomaker bug /cc @scruffian

@mtias mtias added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement. labels Oct 15, 2021
@ntsekouras
Copy link
Contributor

Typography: default size looks "unset".

Could we use a help text here if we have ToggleGroupControl and the value is set to default?

@scruffian
Copy link
Contributor

Buttons inside groups are misaligned. (Might be theme related.)

This was fixed by Automattic/themes#4842

@jasmussen
Copy link
Contributor

Site logo fixed in #35718.

The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

#35637 removes dotted lines on ancestors. That fixes, or starts work on it.

Search in navigation menus is super awkward. It should be possible to get an icon only button that expands inline or in an overlay. This should likely also be the default.

#35688 starts work on it. The issue is also tracked separately in #31127.

@youknowriad
Copy link
Contributor

Disabling theme editor styles in preferences makes some elements in the page load with default colors and not the current color scheme.

I've been trying but failing to reproduce this one. Any more details?

@jasmussen
Copy link
Contributor

I've been trying but failing to reproduce this one. Any more details?

I'm seeing it happen in my block theme when toggling the editor styles off in preferences:
colors

@noisysocks
Copy link
Member

Pages List server-render component is ill-suited and needs to be converted to a proper editor block.

I can look into this.

@tellthemachines
Copy link
Contributor

Navigation block new link would break with no visible signs of recovery — typing the name of the page would not bring the page up.

Not sure how to reproduce this one, or even what's happening. Could we have more detailed steps please?

@noisysocks
Copy link
Member

Menu settings (called Display) should come before the Typography supports and should probably not be in a panel at all (not collapsible).

Fixed by #33744.

@jasmussen
Copy link
Contributor

The amount of lines shown in the site editor to distinguish active focus, hover focus, current template part focus, etc, is wild. We need to reduce this.

Checked this one, as fixed by #35637. I suspect additional fixes can be made, but it fixed the immediate issue.

@Mamaduka Mamaduka added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Oct 29, 2021
@mtias
Copy link
Member Author

mtias commented Nov 26, 2021

This is mostly covered, thanks for the work following up on issues!

@mtias mtias closed this as completed Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

9 participants