Fix site logo block on dark backgrounds. #35718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
16 tasks
|
Size Change: +7 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #35397
The Site Logo setup state has dashed outlines and uses
currentColorto set the color of said outlines. But it looks like this on dark backgrounds:That's because the background wasn't made transparent. This PR fixes that:
How has this been tested?
Try a theme with a dark background and light text, then to insert an empty Site Logo block. You should not see a white background inside the site Logo. You can also test in TT1, where you should see the green background peeking through the setup state.
Checklist:
*.native.jsfiles for terms that need renaming or removal).