getEntityRecords returns null after requesting an "invalid" page

[davilera]

Description

getEntityRecords should return an array of entities (assuming the resolution is finished) that match the queried criteria. However, it sometimes returns null incorrectly.

As far as I can tell, it returns null when:

• requesting a taxonomy (I've only tested category and post_tag)
• there’s up to n pages of entities
• the requested page is n+1 (results in the empty array [])
• followed by a new request with page n (always results in null)

Note. This does not occur with postType post.

Step-by-step reproduction instructions

1. Let’s assume your WordPress site has two categories only.
2. While in Gutenberg, open the browser's developer tools and run:

wp.data.select( 'core' ).getEntityRecords(
  'taxonomy',
  'category',
  { page: 1 }
)

At first, it returns null. After a couple of seconds, when the resolver has finished, it returns a list of two elements: the two categories we created/had in (1).

3. Request the second page:

wp.data.select( 'core' ).getEntityRecords(
  'taxonomy',
  'category',
  { page: 2 }
)

We know there's only two categories, so the second page eventually results in the empty array [].

4. Request the first page again.

wp.data.select( 'core' ).getEntityRecords(
  'taxonomy',
  'category',
  { page: 1 }
)

It should return the list of categories we saw in (2), but the snippet now returns null.

This also occurs if we skip step 2.

Screenshots, screen recording, code snippet

No response

Environment info

• WordPress 5.9
• Gutenberg 12.5.4

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[annezazu]

cc @kevin940726 curious for your thoughts here based on the PR that seems to have made this change: #36984

[katag9k]

I have run into a smiliar issue where wp.data.select('core').getEntityRecords('taxonomy', 'category', { per_page: 100 }); returns [] in Gutenberg WP 5.8.3 but in Gutenberg WP 5.9.0 it returns null and once in a while it will return []

function customizeCategorySelector(PostTaxonomies) {
  
  return function (props) {
    if (props.slug === 'category') {
      var categories = getEntityRecords('taxonomy', 'category', { per_page: 100 });
      console.log(categories);
    }
  };
}

wp.hooks.addFilter('editor.PostTaxonomyType', 'taxonomy_enqueue', customizeCategorySelector);

[Thelmachido]

There hasn't been much activity on this issue in a while, are you able to take a look at this @kevin940726

[Mamaduka]

The issue was reviewed in today's Editor Bug Scrub and has been confirmed.

[kevin940726]

Hi there! Sorry for the late reply! I was busy with other things and forgot about the pings 🙇 (Thanks for re-pinging me though!)

I'm not sure if this bug is related to #36984 though. I'm able to reproduce this bug even after reverting that commit.

I don't have the time to investigate this at the time, unfortunately. Maybe git bisect would help pinpoint the exact commit? I'd love to help investigate this once I have the time though!

[codal-crathod]

I have run into a similar issue where wp.data.select('core').getEntityRecords('taxonomy', 'category', { per_page: 100 }); returns[]in Gutenberg and it returns null.

I am using jQuery.