Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply duotone filter to placeholders for Site Logo & Post Featured Image blocks #40061

Closed
annezazu opened this issue Apr 6, 2022 · 1 comment · Fixed by #40085
Closed

Apply duotone filter to placeholders for Site Logo & Post Featured Image blocks #40061

annezazu opened this issue Apr 6, 2022 · 1 comment · Fixed by #40085
Assignees
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Block] Site Logo Affects the Site Logo Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Apr 6, 2022

What problem does this address?

When applying a duotone filter to a Site Logo or Post Featured Image placeholder, there's no visual indication that anything has been applied. This was found during the 6.0 walkthrough.

duotone.featured.image.mov

What is your proposed solution?

This was previously discussed here #36517 (comment) but it doesn't seem this was ever implemented and/or a regression might have happened. cc @ajlende @jasmussen for more context.

In that discussion, it was noted that a good alternative would be to apply it to the outline and upload button as well (this button only shows when one is adding a post featured image block to a Post or Page rather than at the template level):

Screenshot 2021-11-16 at 21 34 01

It could also just be added to the dashed border:

Screenshot 2021-11-16 at 21 31 02

Note that the above placeholder was updated #36712 so I'm pulling in old screenshots :)

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Featured Image Affects the Post Featured Image Block [Block] Site Logo Affects the Site Logo Block labels Apr 6, 2022
@carolinan carolinan self-assigned this Apr 6, 2022
@jasmussen
Copy link
Contributor

Yes, this used to work. If we're okay with the upload button being colored when a duotone filter is selected — I think it's fine until further optimizations — then this could potentially be a quick win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Block] Site Logo Affects the Site Logo Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants