-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation block: Sub menu background transparent when picking a suggested background color on Varia #42256
Comments
Hi! Which overlay and submenu setting are enabled? As in, "Overlay menu, mobile", "Open on click" "Show arrow". |
I tested the issue using the submenu inside the navigation block. I don't see an option to add a page list as a submenu in the navigation block. Here's a screen recording for your reference - Menu.Navigation.mov
I updated the pagelist block as we figured the fallback style is coming from there.
Yes, the background color is set on the navigation block. I also tried adding the background color to the submenu via the 'Submenu & Overlay background' option but it doesn't work.
'Overlay Menu = Always' => Background color displays fine I am able to reproduce the issue on the big screen if The settings "Open on click" and "Show arrow" didn't matter in my test. I am able to reproduce the issue with both settings enabled and disabled. |
I checked the background color for the submenu is working fine in the default Twenty Twenty Two and Twenty Twenty One theme. Should we handle this change in the Varia theme if it is not impacting other themes? I noticed different themes are handling the colors differently. Seedlet theme adds the extra [class] selector to override the default color. |
Closing this issue as it is theme specific. |
Description
When using the Navigation block with the Varia and its child themes, the background color selected from the block settings is not honored. It is because the specificity of the fallback menu background color is higher than the CSS specificity of the selected block color.
I expect the background color selected for the Navigation block to apply to the submenu.
Step-by-step reproduction instructions
Steps to reproduce
Screenshots, screen recording, code snippet
I created a PR to fix this issue, however it needs further discussion.
Link to the PR: #42211
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: