Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.1.1 - Setting a 49%+ for width of a child column breaks column #46009

Closed
theRealHal9000 opened this issue Nov 23, 2022 · 5 comments
Closed
Labels
[Block] Columns Affects the Columns Block Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended

Comments

@theRealHal9000
Copy link

Description

We previously set % widths for most of our child columns for more granular control. After 6.1.1 those sizes are no longer working/accurate.

Please see the attached recording.

Setting any flex-basis greater than 48% breaks the two columns, forcing the 2nd column down. I understand there are a lot of different factors causing this, but using 50% worked previously, which is why this is head-scratching.

Step-by-step reproduction instructions

  1. Create a new column
  2. Set a column split like 50/50
  3. Add something to the two new blocks
  4. In the two child columns set a column width of 50%

Screenshots, screen recording, code snippet

Uploading Column Width-1.webm…

Environment info

-Wordpress 6.1.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@theRealHal9000 theRealHal9000 changed the title 6.1.1 - Setting a % for the column width of a child column 6.1.1 - Setting a 49%+ for width of a child column breaks column Nov 23, 2022
@kathrynwp kathrynwp added [Type] Bug An existing feature does not function as intended [Block] Columns Affects the Columns Block Needs Testing Needs further testing to be confirmed. labels Nov 23, 2022
@tellthemachines
Copy link
Contributor

Thanks for the report @theRealHal9000 ! Could you add the recording again? It doesn't seem to have uploaded properly.

Going through those steps with Twenty Twenty and Twenty Twenty Three themes, I couldn't reproduce the issue. Are you using a custom theme, or a non-default theme at all? Might there be an incompatibility with the styles from that theme?

@tellthemachines
Copy link
Contributor

Oooh, I wonder if this could be related to #45713

@theRealHal9000
Copy link
Author

flex-basis issue.webm
Hopefully this upload works.

Setting the column width in the editor adds {flex-basis: n%} to wherever. I only tested this with 2 columns at 50%, but there might be more.

@ndiego
Copy link
Member

ndiego commented Nov 29, 2022

This issue was reviewed in today's Editor Bug Scrub. We have been unable to replicate using the latest versions of Gutenberg, WordPress, and the Twenty Twenty-Three theme. I have included a gif below.

Would you be able to share the theme that you are using?

columns

@ndiego ndiego added the [Status] Needs More Info Follow-up required in order to be actionable. label Nov 29, 2022
@ndiego
Copy link
Member

ndiego commented Dec 13, 2022

This issue was reviewed in today's Editor Bug Scrub. We have been unable to replicate using the latest versions of Gutenberg and WordPress. Therefore, I am going to close this issue. If anyone can replicate it in the future, please feel free to reopen this issue with additional information.

@ndiego ndiego closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants