Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent 'Settings' icon in the Post / Site editor and Widgets page #49989

Closed
afercia opened this issue Apr 21, 2023 · 3 comments
Closed
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Apr 21, 2023

Description

In the Post and Site editor, the 'Settings' panel (sidebar) icon has been changed from a cog icon to a drawer icon. See conversation here: #40204 (comment)

Screenshot 2023-04-21 at 16 03 19

I'd have a few arguments against this change, as the new drawer icon only represents the visual aspect and placement of the settings and doesn't tell anything about what it is about. Also, the labelling of the button and of the panel is 'Settings' and I can't see how a drawer can communicate that concept. Visually, to me, the drawer icon is just two rectangles that don't tell me anything useful.

Apparently, the only reason for the change to the drawer icon is that the sidebar can contain other settings with a cog icon:

Screenshot 2023-04-21 at 16 14 00

I'd argue those tabs should use visible text instead of icons, which would solve the top bar settings icon issue.

Regardless, I'd like to point out that in the Widgets page the Settings icon is still a cog:

Screenshot 2023-04-21 at 16 03 42

Whatever the decision is, the top bar Settings icon should be consistent throughout the entire WordPress UI.

Step-by-step reproduction instructions

  • Activate a non-block based theme e.g. Twenty Twenty-One.
  • Go to Appearance > Widgets.
  • Observe the Settings icon in the top bar is still the 'cog' icon.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Post /packages/edit-post [Package] Edit Widgets /packages/edit-widgets [Package] Edit Site /packages/edit-site labels Apr 21, 2023
@joedolson
Copy link
Contributor

I agree with everything @afercia says here. Obviously the key element of this issue is that the icons are inconsistent, and that needs to be fixed.

But I also fully agree that the sidebar icon is confusing, and the change wouldn't have been necessary if the sidebar tabs just used text labels - which would also help users understand what those tabs are for.

@t-hamano
Copy link
Contributor

I believe the icon inconsistency was resolved in #51029. How about closing this issue and discussing whether the icon should be used or not in a new issue?

@afercia
Copy link
Contributor Author

afercia commented Sep 13, 2023

Thanks @t-hamano I'm going to close this issue. I see there is already #46851 to discuss reverting back the icon to the cog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants