Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: More #8974

Closed
6 tasks
sarahmonster opened this issue Aug 14, 2018 · 5 comments
Closed
6 tasks

Block audit: More #8974

sarahmonster opened this issue Aug 14, 2018 · 5 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Aug 14, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screenshot 2018-08-14 14 51 41

Name: More
Description: Want to show only part of this post on your blog’s home page? Insert a "More" block where you want the split.
*Category: Layout elements
CSS class: wp-block-more in editor, none in frontend (uses a #span-xx ID)
Can be converted to: nothing

States

Empty:
screenshot 2018-08-14 14 06 07

Selected:
screenshot 2018-08-14 14 06 07

Unselected:
screenshot 2018-08-14 14 52 50

Placeholder:
screenshot 2018-08-14 14 52 50

Primary (toolbar) settings

None

Secondary (sidebar) settings

Hide the teaser before the "More" tag switch

Frontend appearance

The more tag isn't visible in posts on the front end, so Gutenberg isn't providing any styling here.

Bugs/errors

Individual issues will be opened for these soon

  • [ ]

Suggestions

Individual issues will be opened for these soon

  • The switch isn't contained within any sort of panel in the secondary settings sidebar, which is unlike all other blocks.

  • Should this have a more descriptive name, perhaps?

  • Is there a way to have this block better preview its content/frontend appearance?

  • I don't fully understand what Hide the teaser before the "More" tag switch does. Does this mean that the blog index just shows a "read more" link, and nothing else?

  • Placeholder styling doesn't make it immediately obvious that you can edit the text of the read more tag.

  • Typing "read more" in the slash inserter should pull up the more tag.

@sarahmonster sarahmonster added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Aug 14, 2018
@sarahmonster sarahmonster self-assigned this Aug 14, 2018
@swissspidy
Copy link
Member

Uhm... there used to be a dashed line on the left and right side of the "read more". See #1440

I can still see it in the CSS, but it's not visible. Sounds like a bug to me.

Also, when initially inserting the block, the label "read more" is cut off a few pixels on either side:

screenshot 2018-10-02 at 11 00 55

@afercia
Copy link
Contributor

afercia commented Nov 3, 2018

Was going to create a new issue and then thought to report here.

Individual issues will be opened for these soon

Wasn't able to find specific issues, I guess they haven't been created yet 🙂

I'd recommend to consider to clarify what a "teaser" is and what this setting does, as also mentioned in the 4th suggestion above.

As a user, I'm not supposed to know what a "teaser" is. "Teaser" is a technical term related to typography. Also, I'm not sure how it can be correctly translated. Assuming translators know what a teaser is, typographic terms greatly varies across different countries and cultures.

The setting also doesn't clarify what it actually does: the part of the content before the more tag will be hidden in the single post view.

screenshot 2018-11-03 at 10 35 03

After a quick research for the term "teaser", turns out it is also known as "kicker, stand-first, or deck". Definitions I've found about "teaser" or "kicker":

  • Short, underlined phrase introducing a headline. Also called teaser.
  • A short phrase — set in a small point size — above a main heading. Also known as a kicker.
  • A short line of copy set in a distinctive type above a headline and intended to call attention to it.

So, strictly speaking, it's something that comes before the main headline, while in WordPress this piece of content is used differently. Thus, seems "teaser" is not a correct term in the first place. However, this doesn't help so much. For most users, this is just a portion of content. I'd tend to think the simpler option is to just use the term "content" and clarify it applies to the single post view.

Or

Now that the "More" description a few lines above refers to the "excerpt" (it previously said "part of this post"), maybe leverage the term "excerpt". Considering the two text combined together, seems to me it would help in clarifying. For example:

Want to show only an excerpt of this post on your home page?
Use this block to define where you want the separation.

Hide the excerpt on the post page

Aside: Ideally, the term "post" should be avoided because it could be any custom post type, but this is a different issue... 🙂

@melchoyce
Copy link
Contributor

Related: #6561

@afercia
Copy link
Contributor

afercia commented Dec 28, 2018

The help text has been changed in #11587, but still not so clear:

More
Mark the excerpt of this content.
Content before this block will be
shown in the excerpt on your
archives page.


Hide the teaser before the "More" tag

I'd like to suggest to change it into:

More
Content before this block will be
shown in the excerpt on your
archive pages.


Hide the excerpt on the full content page

@karmatosed
Copy link
Member

I have created an issue for #14103. Some other improvements have been made since the audit. For now, closing this, but if I missed anything I can create new ones please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

5 participants