New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update More block description #11587

Merged
merged 3 commits into from Nov 19, 2018

Conversation

Projects
None yet
6 participants
@Soean
Member

Soean commented Nov 7, 2018

Description

Updates the description of the More block.
Fixes: #11458

Old:
Want to show only an excerpt of this post on your home page? Use this block to define where you want the separation.
New:
Mark the excerpt of this content. Content before this block will be shown in the excerpt on your archives page.

@Soean Soean requested a review from alexislloyd Nov 7, 2018

@ocean90 ocean90 added this to the 4.3 milestone Nov 7, 2018

@youknowriad youknowriad requested a review from WordPress/gutenberg-core Nov 8, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented Nov 8, 2018

It changes more than home page to homepage. @alexislloyd what's your take on the proposed change? It looks like you iterated on it a bit earlier, so I would expect this PR to be scoped to only fix the way home page is used.

@swissspidy

This comment has been minimized.

Member

swissspidy commented Nov 8, 2018

Only fixing homepage everywhere in a more scoped fashion makes sense.

We can then improve the text in a separate PR. Could we then get rid of the "post" bit of the description as well please? Otherwise it's not accurate for other post types. I would replace it with "content".

@tofumatt

I don't like block descriptions that lead with questions. We use an entire sentence to ask the user if this is the block they want to be using before telling them what it does; the question is an indirect way of asking them and I don't think it's very instructive 😄

Show resolved Hide resolved packages/block-library/src/more/index.js Outdated

@gziolo gziolo removed this from the 4.3 milestone Nov 9, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented Nov 9, 2018

I updated home page with homepage with #11661 to land it in 4.3 and resolve the original issue. Feel free to continue discussion on the improvements to this description without the pressure of time :)

tofumatt and others added some commits Nov 13, 2018

Update packages/block-library/src/more/index.js
Co-Authored-By: Soean <soerenwrede@gmail.com>
@tofumatt

Looks good, I say :shipit:

@tofumatt tofumatt added this to the 4.5 milestone Nov 16, 2018

@youknowriad youknowriad merged commit 763bb6b into master Nov 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/more-description branch Nov 19, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Update More block description (WordPress#11587)
* Update More block description

* Update packages/block-library/src/more/index.js

Co-Authored-By: Soean <soerenwrede@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment