-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg 3.8 - 4.1.1 Paragraph Block Thinks Modified Externally if an Emoji Is Used. #9906
Comments
I'm having trouble reproducing this. Could you provide more information on whether there's anything about your site or user which could have an impact here? Specific plugins on the site? User role? |
Same thing happens if I deactivate all plugins except Gutenberg, so that should rule out a plugin conflict? I am using a Twenty Twelve child theme. Also happens on my local PC as well as my webhost. My user role is whatever the highest admin role is. The database table field is defined as: |
Thanks for the bug report, @MarkRH! For anyone wanting to reproduce this bug in the Gutenberg Docker environment, run this command:
Then the steps in the original report will work. |
Is it fair to say that for validation purposes, we should normalize the HTML-encoded form var d = document.createElement( 'div' );
d.innerHTML = '🙁'
d.textContent
// "🙁" Edit: In case its unclear, I don't mean we should hardcode normalization of this single emoji, but between encoded forms and emojis generally. |
Yup, I think that's a reasonable way to do this. |
Gutenberg 3.90. Same thing, but I expected that as no mention in the change log. |
Another instance raised in Slack, specifically relating to export / import flows (link requires registration): https://wordpress.slack.com/archives/C02QB2JS7/p1539622489000100 |
Same happens with 4.1.1, even if I save as a Custom HTML Block, it thinks it was still modified externally when I go back. |
With Gutenberg 4.3.0 when I go to edit a post that had an emoji in it (created with previous version), I still get the message and when I click resolve or convert to HTML the editor does nothing. Still on WP 4.9.8. |
The proposed pull request at #11771 is slated to resolve this. |
Describe the bug
With WordPress 3.9.8 and Gutenberg 3.80, if I paste an emoji into a paragraph block and save the post, when I go to re-edit it, it thinks it has been modified externally. If I click convert to blocks it goes back to the way it was with the emoji still there.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should not think it was modified externally.
Screenshots
Desktop (please complete the following information):
Additional context
In my case, it looks like the emoji is stored in the database as
🙁
which might be why it's being triggered?The text was updated successfully, but these errors were encountered: