Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing Flow: Unset typing flag if Escape pressed #10906

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 22, 2018

Extracted from #10699

This pull request seeks to resolve an issue where the contextual block toolbar is not accessible by keyboard when typing, except by artificially creating a selection for the mere purpose of deactivating the "is typing" application state flag. It does so by canceling the typing mode when the user presses Escape.

Implementation notes:

There are still some undesirable behaviors, of which this is not intended to cover, though I will create issues for:

Testing instructions:

Verify that, after typing in a paragraph block, pressing Escape causes the toolbar to be shown.

@aduth aduth added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Oct 22, 2018
@youknowriad youknowriad added the Needs Accessibility Feedback Need input from accessibility label Oct 23, 2018
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Code wise. Would be good to have a quick accessibility check.

@youknowriad
Copy link
Contributor

I'm still not sure what label we should use "Accessibility" or "Needs Accessibility Feedback" 🤷‍♂️

@aduth aduth mentioned this pull request Oct 24, 2018
4 tasks
@aduth aduth merged commit 0a3090d into master Oct 26, 2018
@youknowriad youknowriad deleted the update/observe-typing-escape branch October 26, 2018 13:01
@youknowriad youknowriad added this to the 4.2 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants