New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing Flow: Unset typing flag if Escape pressed #10906

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Oct 22, 2018

Extracted from #10699

This pull request seeks to resolve an issue where the contextual block toolbar is not accessible by keyboard when typing, except by artificially creating a selection for the mere purpose of deactivating the "is typing" application state flag. It does so by canceling the typing mode when the user presses Escape.

Implementation notes:

There are still some undesirable behaviors, of which this is not intended to cover, though I will create issues for:

  • There is special handling of a new paragraph block to consider it as "not yet a paragraph block", thus requiring some typing to occur before Escape will work. Ideally the behavior is made consistent so that Escape will always activate the toolbar.
  • Alt+F10 should navigate into the block toolbar regardless whether it is currently visible.

Testing instructions:

Verify that, after typing in a paragraph block, pressing Escape causes the toolbar to be shown.

@youknowriad

LGTM 👍 Code wise. Would be good to have a quick accessibility check.

@youknowriad

This comment has been minimized.

Contributor

youknowriad commented Oct 23, 2018

I'm still not sure what label we should use "Accessibility" or "Needs Accessibility Feedback" 🤷‍♂️

@aduth aduth referenced this pull request Oct 24, 2018

Merged

Fix rich text value for nested lists #10799

4 of 4 tasks complete

@aduth aduth merged commit 0a3090d into master Oct 26, 2018

2 checks passed

codecov/project 48.41% (-0.26%) compared to 0262373
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/observe-typing-escape branch Oct 26, 2018

@youknowriad youknowriad added this to the 4.2 milestone Oct 26, 2018

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment