Add more information to unsupported blocks on native #14577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
added
the
Mobile App - i.e. Android or iOS
koke
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
koke
changed the title
etoledom
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
Looks and works good! Tested via wordpress-mobile/gutenberg-mobile#643 (review)
I'm not sure about the failing test. It doesn't say much. Maybe we could try to re-run it?
I left a small code comment but not a blocker.
Great job! 🎉
| import styles from './style.scss'; | ||
|
|
||
| export default class UnsupportedBlockEdit extends Component { | ||
| render() { |
There was a problem hiding this comment.
This could be written as a stateless component, since we are not using local state or lifecycle methods.
At my understanding, they are quite faster.
This was referenced Apr 15, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the previous mobile-specific unsupported block, and moves the logic to a native variant of
core/missing.We also now import every core block, even though we only register those supported. This allows us to access the localized block title and icon, so we can show which kind of unsupported block we're dealing with. If the missing block is not a core block, a generic icon and label are shown instead.
How has this been tested?
Testing details on the gutenberg-mobile PR wordpress-mobile/gutenberg-mobile#643
Screenshots