Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: HTML entities in Author name are not decoded #15090

Merged

Conversation

Projects
None yet
5 participants
@foysalremon
Copy link
Contributor

commented Apr 21, 2019

Description

  • Imported decodeEntities from WordPress dependencies on post-author module in packages > editor > src > components >post-author directory
  • Change author.name to decodeEntities(author.name) on same file

How has this been tested?

Tested on WordPress 4.9 using the dev build of this repu on xampp local environment

Types of changes

  • Single JS file change
  • No related or non-related code or functionality have no change to be broken.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@foysalremon

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

This is my first contribution. Please assist me if I am doing anything wrong.

@youknowriad youknowriad requested a review from WordPress/gutenberg-core Apr 22, 2019

Update packages/editor/src/components/post-author/index.js
Co-Authored-By: foysalremon <foysalremon@users.noreply.github.com>
@youknowriad
Copy link
Contributor

left a comment

Any security concern here @aduth

@aduth

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Any security concern here @aduth

It should be fine (reference).

@nenoken

This comment was marked as off-topic.

Copy link

commented May 6, 2019

@aduth aduth merged commit 1d81635 into WordPress:master May 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@foysalremon foysalremon deleted the foysalremon:html-entities-in-author-name-decoded branch May 6, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.