Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: HTML entities in Author name are not decoded #15090

Merged
merged 2 commits into from
May 6, 2019
Merged

Fix: HTML entities in Author name are not decoded #15090

merged 2 commits into from
May 6, 2019

Conversation

foysalremon
Copy link
Contributor

@foysalremon foysalremon commented Apr 21, 2019 •
edited
Loading

Description

  • Imported decodeEntities from WordPress dependencies on post-author module in packages > editor > src > components >post-author directory
  • Change author.name to decodeEntities(author.name) on same file

How has this been tested?

Tested on WordPress 4.9 using the dev build of this repu on xampp local environment

Types of changes

  • Single JS file change
  • No related or non-related code or functionality have no change to be broken.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@foysalremon
Copy link
Contributor Author

This is my first contribution. Please assist me if I am doing anything wrong.

@youknowriad youknowriad added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Apr 22, 2019
@youknowriad youknowriad requested a review from a team April 22, 2019 11:06
@foysalremon foysalremon mentioned this pull request Apr 23, 2019
Closed
@Rahe @foysalremon
Update packages/editor/src/components/post-author/index.js
f05e464 
Co-Authored-By: foysalremon <foysalremon@users.noreply.github.com>
youknowriad
youknowriad approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any security concern here @aduth

@aduth
Copy link
Member

aduth commented May 6, 2019

Any security concern here @aduth

It should be fine (reference).

@nenoken

This comment has been minimized.

Sign in to view
@aduth aduth merged commit 1d81635 into WordPress:master May 6, 2019
@foysalremon foysalremon deleted the html-entities-in-author-name-decoded branch May 6, 2019 17:59
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahe Rahe Rahe left review comments

@youknowriad youknowriad youknowriad approved these changes

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
5.7 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
5 participants
@foysalremon @aduth @nenoken @youknowriad @Rahe