Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding regression with appender #18865

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Fix padding regression with appender #18865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bff944f
Remove horizontal margin from generic appender.
jasmussen Dec 2, 2019
3d18adf
Fix similar issue for columns.
jasmussen Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-list-appender/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// These styles are only applied to the appender when it appears inside of a block.
// Otherwise the default appender may be improperly positioned in some themes.
.block-editor-block-list__block .block-list-appender {
margin: $block-padding;
margin: $block-padding 0;

// Add additional margin to the appender when inside a group with a background color.
// If changing this, be sure to sync up with group/editor.scss line 13.
Expand Down
6 changes: 0 additions & 6 deletions packages/block-library/src/columns/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,6 @@
margin-top: $block-padding*2;
margin-bottom: $block-padding*2;
}

// When the individual column block is selected, the nested padding overrules
// some of this margin. We need to adjust the appender spacing again as a result.
[data-type="core/column"].is-selected .block-list-appender {
margin: $block-padding 0;
}
}

/**
Expand Down