Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved "Welcome guide" link to options modal dialog #19499

Open
wants to merge 1 commit into
base: master
from

Conversation

@mapk
Copy link
Contributor

mapk commented Jan 7, 2020

Description

Fixes #19443.

Move the Welcome Guide link to the Option modal dialog. It is now under the "General" category next to the "Inserter Help Panel" which seems fitting. This is in an effort to help alleviate the redundancy of two "Tools" sections in the interface as recorded in #19409.

How has this been tested?

Tested locally.

Screenshots

Option modal dialog

Screen Shot 2020-01-07 at 2 25 37 PM

Gif of interaction

welcome-guide 2020-01-07 14_21_28

Types of changes

Moving a link from one location to another. Non-breaking, maybe?

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@mapk

This comment has been minimized.

Copy link
Contributor Author

mapk commented Jan 7, 2020

One concern I have is that by adding this to the Options modal dialog, when I click to check this feature "on", the dialog disappears immediately and the Welcome Guide appears.

Is this okay a11y-wise? Design-wise?

@mapk mapk requested a review from noisysocks Jan 7, 2020
@mapk mapk self-assigned this Jan 7, 2020
@@ -13,7 +13,6 @@ import CopyContentMenuItem from './copy-content-menu-item';
import ManageBlocksMenuItem from './manage-blocks-menu-item';
import KeyboardShortcutsHelpMenuItem from './keyboard-shortcuts-help-menu-item';
import ToolsMoreMenuGroup from '../components/header/tools-more-menu-group';
import WelcomeGuideMenuItem from './welcome-guide-menu-item';

This comment has been minimized.

Copy link
@noisysocks

noisysocks Jan 16, 2020

Member

Since this change means that it is no longer used anywhere, let's delete the packages/edit-post/src/plugins/welcome-guide-menu-item directory as part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.