Navigation: Improve flow when creating from menu #23187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user opts to create a Navigation block from an existing menu, let them click on the Create button immediately while we fetch the menu items in the background. This way we avoid disabling the Create button which is a confusing UX.
noisysocks
added
[Type] Enhancement
|
Size Change: +15 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jun 16, 2020
talldan
approved these changes
Jun 16, 2020
This was referenced Jun 24, 2020
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23055.
When the user opts to create a Navigation block from an existing menu, let them click on the Create button immediately while we fetch the menu items in the background. This way we avoid disabling the Create button which is a pretty confusing UX.
To test:
/wp-admin/nav-menus.php.Note that the Create button remains enabled while menu items are loaded in the background.