Check nav is editable before counting items #24146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
talldan
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
This makes sense. Since #23187 was merged there might still be an in-flight HTTP request for the menu items after the create button is clicked, which would result in the items not being created immediately.
I'm guessing that even though the endpoints are mocked things are still happening asynchronously.
With the changes in #23187 there's probably some code that can be removed as well. I don't think the button is ever disabled:
https://github.com/WordPress/gutenberg/blob/master/packages/e2e-tests/specs/experiments/navigation.test.js#L236-L243
tellthemachines
force-pushed
the
fix/nav-e2e-test
branch
from
020d2f7
to
b3ece1c
Compare
Oh, well spotted! Might remove that separately though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23876 (hopefully 😅) by checking that the Nav block is no longer in placeholder mode before counting its items. Given that the test fails because it doesn't find the items on the page, but in the very next check the same items are correctly rendered in a snapshot, I'm guessing it's a timing issue.
How has this been tested?
It's very hard to reproduce the issue locally, but I've managed to do so by running
THROTTLE_CPU=4 npm run test-e2e packages/e2e-tests/specs/experiments/navigation.test.js. As it's an intermittent failure, it's hard to know for sure if this change has actually fixed the issue or not 😬Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: