Build Tooling: Update development tools to work with PostCSS 8 #27821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
|
From the changelog:
So we have to require this now by ourself which means we could switch to PostCSS 8. This would also mean we have to update postcss-themes. |
|
Size Change: +1.64 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Dec 18, 2020
Yes, it looks like it's necessary. It also indirectly satisfies the need for having |
gziolo
added
the
[Type] Breaking Change
gziolo
force-pushed
the
update/wordpress-scripts-postcss
branch
from
e8d5dc3
to
41fcfd8
Compare
|
With 41fcfd8 I tried to upgrade I will try again with fewer changes applied and a separate effort to fix |
gziolo
force-pushed
the
update/wordpress-scripts-postcss
branch
2 times, most recently
from
42201e1
to
9b28f71
Compare
gziolo
changed the title
postcss-loader dependency to ^4.1.0.
|
Now that revert for webpack 5 upgrade landed with #27974, I updated this PR to work with weback 4 and PostCSS 8. In my testing, it works correctly with Gutenberg, but also with Create Block. |
|
@gziolo Did you see my comment in #27028 (comment)? |
I missed it :( It looks like all those issues are still present:
|
gziolo
force-pushed
the
update/wordpress-scripts-postcss
branch
from
2db372c
to
2a67a85
Compare
|
I rebase this branch with the latest changes in
We are only waiting for the next version of Storybook |
gziolo
changed the title
gziolo
added
the
[Package] PostCSS Plugins Preset
|
I executed There is only 5 blocking items to finish to see the stable version of Storybook: |
gziolo
force-pushed
the
update/wordpress-scripts-postcss
branch
from
edec3e6
to
fa54c88
Compare
|
Updated Storybook to the RC8 in fa54c88. There are 3 issues left in the milestone that block its stable release that don't impact Gutenberg. |
gwwar
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
Thanks for looking into this. This smoke tests okay for me 👍 Folks might want to double check that package-lock.json is generated correctly, since the changes look a little large.
I tested this with:
npm run distclean
npm run install
npm run build
npm run dev
npm run storybook:build
npm run storybook:dev
npm run test:create-blockOutput of test:create-block
gziolo
force-pushed
the
update/wordpress-scripts-postcss
branch
from
fa54c88
to
3da5c1f
Compare
It's coming mostly from the Storybook upgrade. I guess it's inevitable with the number of changes they introduce 😞 |
|
This seems to have broken When I encountered this I'd just merged trunk and noticing the package(-lock).json changes, I ran I'm using macOS 10.12.6. It doesn't seem like the changes here should have caused an issue. Maybe there's something else I could try besides the revert. Or a way I could get a better idea of what caused wp-scripts to exit. Any ideas would be much appreciated. |
|
Yes something here breaks file watching in |
|
Another attempt in #30347. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27028.
This should allow to use @wordpress/scripts with PostCSS 8 but doesn't actually require it since it doesn't have it as a dependency at all.
See also https://github.com/webpack-contrib/postcss-loader/blob/v4.1.0/CHANGELOG.md
How has this been tested?
npm run devandnpm run buildstill work properly,Create Block still build correctly. Testing is a bit cumbersome but it follows what happens on CI (https://github.com/WordPress/gutenberg/blob/master/bin/test-create-block.sh):
npx wp-create-block esnext-example --no-wp-scriptscd esnext-example../node_modules/.bin/wp-scripts startbuildfolder.../node_modules/.bin/wp-scripts buildbuildfolder.Checklist: