Interface: Replace store name string with exposed store definition #28041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelgallani
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +32 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
|
E2e test failure seems unrelated and very often present in other CI runs these days :( |
gziolo
added
[Type] Code Quality
17 tasks
@gziolo about that CI issue, I was able to reproduce it locally! |
Sounds awesome! PR is more than welcome ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #27088. Replaces the store names (hardcoded strings) with the exposed
storedefinitions.How has this been tested?
npm run test.Types of changes
Code refactoring, non-breaking change.
Checklist: