Add element-selector to group block #28576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +121 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Tested with TT1 Blocks, works well. |
ZebulanStanphill
added
[Block] Group
mtias
reviewed
Jan 30, 2021
|
@aristath, any idea why so many e2e tests related to FSE fail with this branch? The change proposed to align with the Group block makes sense. I like that it's inside the advanced section since it's very technical but shares the same characteristics as the class name or anchor. |
It doesn't seem to be related to this PR... I can see the same tests are currently failing on the |
mtias
approved these changes
Feb 1, 2021
This was referenced May 4, 2021
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
May 25, 2021
`main` is a valid HTML element that is especially valuable for KSES to support in light of full site editing. Related: WordPress/gutenberg#28576 for the addition of `main` to the group block. Fixes #53156. Props glendaviesnz. git-svn-id: https://develop.svn.wordpress.org/trunk@50987 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
May 25, 2021
`main` is a valid HTML element that is especially valuable for KSES to support in light of full site editing. Related: WordPress/gutenberg#28576 for the addition of `main` to the group block. Fixes #53156. Props glendaviesnz. git-svn-id: https://develop.svn.wordpress.org/trunk@50987 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
May 25, 2021
`main` is a valid HTML element that is especially valuable for KSES to support in light of full site editing. Related: WordPress/gutenberg#28576 for the addition of `main` to the group block. Fixes #53156. Props glendaviesnz. Built from https://develop.svn.wordpress.org/trunk@50987 git-svn-id: http://core.svn.wordpress.org/trunk@50596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
May 25, 2021
`main` is a valid HTML element that is especially valuable for KSES to support in light of full site editing. Related: WordPress/gutenberg#28576 for the addition of `main` to the group block. Fixes #53156. Props glendaviesnz. Built from https://develop.svn.wordpress.org/trunk@50987 git-svn-id: https://core.svn.wordpress.org/trunk@50596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
F-Wilke
pushed a commit
to FiliagoDev/WordPress
that referenced
this pull request
Jul 31, 2021
`main` is a valid HTML element that is especially valuable for KSES to support in light of full site editing. Related: WordPress/gutenberg#28576 for the addition of `main` to the group block. Fixes #53156. Props glendaviesnz. Built from https://develop.svn.wordpress.org/trunk@50987 git-svn-id: http://core.svn.wordpress.org/trunk@50596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of #27101
In that PR we added an element selector to the template-part block. This PR copies the same logic to group blocks.
Came up in WordPress/theme-experiments#180 where it became evident that the
<main>element was missing in the theme. Though editing it in templates is the preferred way to handle things for theme-included templates, there's currently no way to do the same for user-created templates.How has this been tested?
Tested with existing group blocks and verified nothing breaks, there's no backwards-compatibility issues.
Tested with new group blocks and verified that the tag gets properly applied, saved and presented.
Screenshots
The control was added to the Advanced section - just like in the template-part block.
Checklist:
I've included developer documentation if appropriate.I've updated all React Native files affected by any refactorings/renamings in this PR.