Add mechanism to translate custom page templates #28783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
oandregal
commented
Feb 5, 2021
oandregal
added
[Feature] Templates API
This was referenced Feb 9, 2021
whether they are unknow keys or numeric.
oandregal
force-pushed
the
add/page-templates-translation
branch
from
34d04dd
to
09a447a
Compare
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
This was referenced Feb 12, 2021
|
I've explored an alternative way to translate fields in |
9 tasks
|
I'm going to close this as there's an alternative PR at #29828 that addresses this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27778 introduced a new field in the
theme.jsonfile, thepageTemplatesto declare custom page templates to be shown to the user in places like:#28700 integrated the processing of that field into the
WP_Theme_JSON/WP_Theme_JSON_Resolverclasses. This is the next step of that integration: make it translatable.Changes:
experimental-i18n-theme.json, so wp-cli can understand what needs to be translated.WP_Theme_JSON_Resolverto retrieve the translated version of this field.