WP_Theme_JSON_Resolver: update translate terminology #28944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
the
[Type] Code Quality
oandregal
changed the title
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
aristath
approved these changes
Feb 11, 2021
oandregal
force-pushed
the
update/translate-terminology
branch
from
8fbd28f
to
ce74abd
Compare
|
I see there's reported by rnmobile-android-runner https://github.com/WordPress/gutenberg/actions/runs/558545439
It's unrelated to these changes so I'm going to merge to continue work on #28783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on adding a new path to translate from the
theme.jsonat #28783 I found myself wanting to do some refactorings prior. I thought it'd be easier to review if we tidy first, and then make the behavioral changes after.How to test
This PR doesn't introduce any behavioral change, so it's enough to activate TT1-blocks theme and load the front-end and editors. See that everything works as expected.