Widget editor: Add toolbar button to move between widget areas #30826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
|
Size Change: +33 kB (+2%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
talldan
requested review from
adamziel,
ajitbohra,
draganescu,
ellatrix,
kevin940726,
nerrad,
noisysocks,
ntwb and
tellthemachines
as code owners
draganescu
approved these changes
Apr 15, 2021
|
Nice work.
Yes what other code is duplicated between |
|
It might be an option to move the legacy widget block out of the block library. At a quick glance I don't think there's much else. Maybe we should avoid introducing this package too soon. |
This was referenced Apr 16, 2021
|
Hey I just noticed the icon which reminds me of a "slalom slope" look a like icon in the toolbar. Hovering and clicking showed me that it is the "Move to Widget area" icon. I did a quick search online and came across this icon: https://cdn4.iconfinder.com/data/icons/proglyphs-computers-and-development/512/Move-512.png
With the new icon I found I did quick mockup. |
|
cc. @critterverse for thoughts on the icon. |
|
|
|
A suggestion would be to have a Filmstrip style icon. I mocked one up, but not an icon designer myself, so someone more experienced could iterate on it. Possibly put an arrow inside the main box, if that's better (or not).
|
|
Hey all, I'm questioning whether this should be treated as a primary action that lives in the toolbar. What if it goes into the ellipses menu with other secondary actions? In this case, we could treat the widget area selection as a modal (vs. how it currently appears as a popover from the toolbar):
I think this could help because we've got a lot of different arrow-based icons which starts to get confusing, and "move to widget area" is a tricky thing to communicate clearly in icon format. |
|
Nice. I think the text based option is the clearest way to go. |
|
I went ahead and added this new issue: (As we need to move the discussion out of the merged PR.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progresses #27409.
Implements a toolbar button for all (non-widget area) blocks to allow them to switch between widget areas.
Some notes on the implementation:
How has this been tested?
Added an e2e test
Manual testing
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).