-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Library: Ensure there is no direct import from core/editor store #32866
Conversation
Size Change: -17 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for fixing. These blocks are removed during tree shaking in wordpress-develop
so this change is really just to make the linter happy.
@youknowriad, this one is ready to backport. It should make CI pass again in I identified a PR that might be the reason of false positives in the |
Description
Addressed ESLInt rule violation for the missing import for
@wordpress/editor
in@wordpress/block-library
.@noisysocks removed
@wordpress/editor
as a dependency from@wordpress/block-library
in #32801. It was discovered as an issue by @youknowriad in #32848.We want to keep the hard rule about dependencies as proposed by @noisysocks so this PR copies the workaround used. A proper fix is going to be discussed in #32842.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).