Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: canInsertBlockType() returns false positive #37625

Conversation

delowardev
Copy link
Contributor

@delowardev delowardev commented Dec 25, 2021

Description

For those blocks doesn't support multiple, wp.data.select( 'core/block-editor' ).canInsertBlockType( 'core/more' ) should return false if that block already inserted.

How has this been tested?

Screenshots

Peek.2021-12-20.14-33.mp4

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@delowardev delowardev marked this pull request as draft December 25, 2021 09:03
@delowardev delowardev closed this Dec 25, 2021
@delowardev delowardev deleted the fix/selector-can-insert-block-type branch December 25, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant