Paste: reuse file transforms for file pasting #45891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +15 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/files-paste-transforms
branch
from
df52970
to
5288158
Compare
|
I just gave it a quick test from the angle of the Gallery/Image paste side and this change doesn't affect anything there at all - the Gallery block ignores pastes as it does in trunk at the moment, only drag and drop works (would be nice to enable paste at some point), and the Image block only accepts image file pastes ... but pasting elsewhere in canvas works for video file as advertised. |
Ah nice, I didn't know that. Yes, let's enable that in a separate PR. I don't want to overcomplicate this one right now. |
ntsekouras
force-pushed
the
fix/files-paste-transforms
branch
from
27a8cc8
to
08cff36
Compare
|
@glendaviesnz Could you test again with Gallery and review the changes to the gallery block? We made some changes. |
glendaviesnz
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Nice! Pasting images with the gallery block placeholder selected now adds those images to the gallery, and all other gallery functions seem to work as expected.
Pasting non-image files onto the gallery placeholder replaces the gallery block with the relevant block type, eg. video or file block. This is different to the behaviour when dragging and dropping invalid file types onto the placeholder, in which case they are rejected with a message about invalid file type. It would be good if the behaviour was the same in both cases, but I don't have an opinion about which would be preferred, and I don't think it should hold up this PR.
All the other pasting worked as expected for me with these changes, ie. single and multiple image, video or pdf files pasted in the canvas created the relevant blocks.
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Paste: reuse file transforms for file pasting * Make sure files is defined * paste multiple file types * fix for gallery block * Make sure gallery block settings sync Co-authored-by: ntsekouras <ntsekouras@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #45408.
Don't know why this hasn't come up before. Guess no one tried to paste videos or audio before?! 😄
My only concern with this (and for dropping files) is that it assumes all the files will be off the same block type. That should be fixed...
Requesting some reviews here of people that have previously worked on adding the transforms for dropping files.
Why?
Currently it's not possible to paste anything but image files.
How?
This PR reuses the
filestransforms that we already have on blocks for file pasting also, instead of creating some HTML with blob URLs to run through the raw handler.Testing Instructions
Copy a video and paste it in Gutenberg.
Screenshots or screencast