-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - Unsupported block editor test update #45975
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Mobile App - Automation
Label used to initiate Mobile App PR Automation
labels
Nov 22, 2022
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
Size Change: -3 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
…utton of the WebView instead. For Android it will force setting the Data network connection to avoid issues loading the WebView.
…erter where the enter key would fail to create the block and instead it creates a new Paragraph block
geriux
force-pushed
the
rnmobile/fix/unsupported-block-editor-flaky-test
branch
from
November 23, 2022 13:15
b6cfd73
to
4f373f3
Compare
geriux
commented
Nov 23, 2022
|
||
async setNetworkConnection( connection = 4 ) { | ||
// 4 = Data only | ||
if ( isAndroid() ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only supported on Android and iOS doesn't have this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - Automation
Label used to initiate Mobile App PR Automation
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR:
Gutenberg Mobile PR
-> [Mobile] - Unsupported block editor test update wordpress-mobile/gutenberg-mobile#5277What?
There are constant failures on Android running this test, this PR addresses the issue.
Why?
Because this test is failing all the time.
How?
TBD
Testing Instructions
CI checks should pass in Gutenberg Mobile.
Screenshots or screencast
N/A