Return focus more from focus return hook #52710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +35 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
tellthemachines
added
[Type] Bug
tellthemachines
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Thanks for fixing this!
Tested opening modals from the command palette and closing them; focus returns to the element selected at the point the command palette was opened, whether it was opened with Cmd+K or through the button in the document actions bar (this button has no visible keyboard focus styles btw; not sure if this bug has been previously reported?)
Also tested opening and closing menus and dropdowns such as colors, gradients, the options menu in the top bar and some of the modals that can be accessed from it, and everything still works as expected.
priethor
added
[Focus] Accessibility (a11y)
|
Thank you for testing 🙇 I wanted to try adding a unit test for this but probably won't find the time very soon.
Well spotted. I couldn't find a report after a brief search through open issues. |
That would be great! But for now, let's merge this as is so the fix can still make it into RC2. |
|
I just cherry-picked this PR to the update/further-bugfixes-rc2 branch to get it included in the next release: 3ccb2ef |
tellthemachines
removed
the
Backport to WP Beta/RC
ramonjd
added a commit
that referenced
this pull request
Jul 25, 2023
* Fix image block v6 deprecation (#52822) * Remove incorrect comment * Add missing attribtes and supports * Add integration tests for the deprecation * Fix incorrect import * Fix fixtures * Image: Use the correct method for caption class in recent deprecation (#52853) * Distraction Free: Fix notices in site editor (#52867) * Distraction Free: Add missing command in site editor (#52868) * Site Editor: Fix the template parts link on the list page (#52891) * Return focus more from focus return hook (#52710) * Disambiguate "Import" button string. (#52907) * Disambiguate "Import" button string. * Add _x to import --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> * My patterns page: Increase color contrast for the toggle group (#52678) * Update style.scss * Update style.scss * Check if object exists before accessing its properties. (#52870) * Check if object exists before accessing its properties. * Name anonymous functions * Update names * Sidebar: Restore Back buton 'go to parent' functionality (#52910) * Global styles revisions: display text if no revisions are found (#52865) * If somehow a user lands on the revisions panel when there are no revisions, show some helpful text rather than a loading spinner. Also, add an E2E test! * Updated unit tests to reflect resolver logic changes * Use existing string * Only open edit view when testing the revisions panel itself * ResizableFrame: Account for window resizing (#52697) * ResizableFrame: Account for window resizing * Don't memoize --------- Co-authored-by: Robert Anderson <robert@noisysocks.com> * Distraction Free: Fix conflict with showListViewByDefault preference (#52914) * Backporting changes from WordPress/wordpress-develop#4891 * Site Editor: Open template parts in view canvas view mode (#52916) --------- Co-authored-by: Alex Lende <alex+github.com@lende.xyz> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: Jb Audras <audrasjb@gmail.com> Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Lena Morita <lena@jaguchi.com> Co-authored-by: ramon <ramonjd@gmail.com>
|
Thank you for working on this ❤️
@tellthemachines yes it is reported at #51460. A fix is available at #52246 waiting for review since a while. See also #51729. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Supports sequential dialogs sharing the element to which focus should return once the last dialog is dismissed.
Why?
With the introduction of the command palette and its commands that launch other dialogs there is now greater potential for exposure to focus loss from successive dialogs. This addresses part of #52301.
How?
Updates the compose package’s focus return hook to track the first focus origin and fallback to returning focus there as appropriate.
Testing Instructions for Keyboard
Screenshots or screencast
Before
before-modal-chain-drops-focus.mp4
After
after-modal-chain-keeps-focus.mp4