Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick bugfixes for 6.3.2 #53623

Merged
merged 22 commits into from
Sep 1, 2023
Merged

Cherry-pick bugfixes for 6.3.2 #53623

merged 22 commits into from
Sep 1, 2023

Commits on Aug 31, 2023

  1. Update document title buttons radius (#53221)

    @jameskoster @tellthemachines
    jameskoster authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    79e56b6 View commit details
    Browse the repository at this point in the history

  2. Fix: Sync status overlaps for some languages in Patterns post type pa… 

    …ge (#53243)
    @t-hamano @tellthemachines
    t-hamano authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    0524c65 View commit details
    Browse the repository at this point in the history

  3. Image block: Fix stretched images constrained by max-width (#53274) 

    * Fix dragging to resize from stretching image in the frontend

* Add image block v7 deprecation

* Update deprecation comment

* Prevent image losing its aspect ratio at smaller window dimensions

* Revert "Prevent image losing its aspect ratio at smaller window dimensions"

This reverts commit 8ac9f8c.

---------

Co-authored-by: scruffian <ben@scruffian.com>
    @ajlende @scruffian @tellthemachines
    2 people authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    3a9178a View commit details
    Browse the repository at this point in the history

  4. Image Block: Don't render DimensionsTool if it is not resizable (#5… 

    …3181)
    @t-hamano @tellthemachines
    t-hamano authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    d564a13 View commit details
    Browse the repository at this point in the history

  5. Fix missing Replace button in content-locked Image blocks (#53410) 

    * Revert "don't display BlockContextualToolbar at all in contentonly locking (#53110)"

This reverts commit 5efce0e.

* Alternative fix to hide BlockContextualToolbar when there are no controls
    @noisysocks @tellthemachines
    noisysocks authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    baefb67 View commit details
    Browse the repository at this point in the history

  6. fix the go to for non pages by showing it only for pages (#53408)

    @draganescu @tellthemachines
    draganescu authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    cc90b61 View commit details
    Browse the repository at this point in the history

  7. Site Editor: Fix document actions label helper method (#52974) 

    * Site Editor: Fix document actions label helper method
* Add missing useSelect dep
* Fix e2e tests
* Move the label map at the file level to avoid recreating the object on every render
    @Mamaduka @tellthemachines
    Mamaduka authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    340df75 View commit details
    Browse the repository at this point in the history

  8. Image: Clear aspect ratio when wide aligned (#53439)

    @ajlende @tellthemachines
    ajlende authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    3f0c87a View commit details
    Browse the repository at this point in the history

  9. RichText: Remove 'Footnotes' when interactive formatting is disabled (#… 

    …53474)

Introduce a new 'interactive' setting for format types
    @Mamaduka @tellthemachines
    Mamaduka authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    2c25cd2 View commit details
    Browse the repository at this point in the history

  10. Preserve block style variations when securing theme json (#53466) 

    * Preserve block style variations when securing theme json

Valid and safe block style variations were being removed by
`WP_Theme_JSON_Gutenberg::remove_insecure_properties` when securing the
theme.json. When this was a problem varied depending upon site
configuration, but out-of-the-box it was a problem for administrators on
multi-site installs.

This change adds explicit processing of variations in
`remove_insecure_properties` so that they won't get removed.

* Add another variation sanitisation test

This test checks that when removing insecure properties an
unknown/unsupported property is removed from the variation.
    @dsas @tellthemachines
    dsas authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    6e1ddbf View commit details
    Browse the repository at this point in the history

  11. Site editor: add missing i18n in HomeTemplateDetails (#53543) 

    * Site editor: add missing i18n in `HomeTemplateDetails`

* Lint fix
    @swissspidy @tellthemachines
    swissspidy authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    e46b446 View commit details
    Browse the repository at this point in the history

  12. Fix: Snack bar not fixed on certain pages in the Site Editor (#53207)

    @tellthemachines
    tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    4c487cd View commit details
    Browse the repository at this point in the history

  13. Fix document title alignment in command palette button (#53224)

    @jameskoster @tellthemachines
    jameskoster authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    1cb6459 View commit details
    Browse the repository at this point in the history

  14. Fallback to default max viewport if layout wide size is fluid. (#53551)

    @tellthemachines
    tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    96b6b1e View commit details
    Browse the repository at this point in the history

  15. Link Control: persist advanced settings toggle state to preferences i… 

    …f available (#52799)

* Link Control: Create a preference for whether the advanced section is open

* move the useSelect to the component that uses it

* Supply preference setter via settings

* Pass setter to Post Editor

* Provide local state fallbacks in absence of preference store settings

* Conditionalise display of settings drawer to “edit” mode only

* Extract to constant to improve comprehension

* Fix bug in preferences resolution

* Improve comments

* Add e2e scaffold

* Fix e2e test to correctly assert on feature

* Remove focused test

* Reinstate original logic to hide settings when not required

* Scaffold documentation

* Revert providing prefs via settings

* Refactor to use `core/block-editor` as preference scope

* Update docs

* Reinstate remaining original conditional

* tentative fix for the e2e test

* Try a different syntax for shiftAlt

* another attempt to fix the e2e test

---------

Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com>
    @scruffian @getdave
    @MaggieCabrera @tellthemachines
    3 people authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    d5275a5 View commit details
    Browse the repository at this point in the history

  16. Add tests for fluid layout + typography (#53554)

    @tellthemachines
    tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    7605074 View commit details
    Browse the repository at this point in the history

  17. Fix support of sticky position in non-iframed post editor (#53540) 

    * Fix support of sticky position in non-iframed post editor
    @stokesman @tellthemachines
    stokesman authored and tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c81f322 View commit details
    Browse the repository at this point in the history

  18. Revert "Footnotes: Fix recursion into updating attributes when attrib… 

    …utes is not an object (#53257)"

This reverts commit ab04074.
    @tellthemachines
    tellthemachines committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    0139ded View commit details
    Browse the repository at this point in the history

  19. Fix: indicator style when block moving mode (#53972)

    @t-hamano @ramonjd
    t-hamano authored and ramonjd committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    093496a View commit details
    Browse the repository at this point in the history

  20. Fix post editor top toolbar with custom fields in Safari (#53688)

    @draganescu @ramonjd
    draganescu authored and ramonjd committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    7f41dd3 View commit details
    Browse the repository at this point in the history

  21. Set top toolbar size dynamically (#53526) 

    * fix the top toolbar size in the space remaining after plugin items are pinned

* only resize above the tablet breakpoint

* fix fixed block toolbar collapse button when icon labels are shown

* Update height and scroll behavior

* move the layout effect to the affected component, fixes for fullscreen, no block selected, icon labels height

---------

Co-authored-by: jasmussen <joen@automattic.com>
    @draganescu @jasmussen @ramonjd
    2 people authored and ramonjd committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    6ae0c48 View commit details
    Browse the repository at this point in the history

  22. Roll back camelCase change in 96b6b1e

    @ramonjd
    ramonjd committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    d67ed5e View commit details
    Browse the repository at this point in the history