Update WPCS to v3.0, and fix all reported Coding Standards issues

[aristath]

What?

Updates WPCS to v3.0

Why?

A few days ago v3.0.0 of the WPCS package was released by @jrfnl.
More details about the package and v3.0 can be found on the post on https://make.wordpress.org/core/2023/08/21/wordpresscs-3-0-0-is-now-available/

Updating the package will ensure that Gutenberg is compatible with PHP versions greater than 8.x, and enforces stricter rules for consistency.

How?

• Updated the package
• Ran phpcbf to fix some spacing issues and all the "simple" stuff
• Ran phpcs and manually fixed the remaining issues

Testing Instructions

If automated tests pass we're good.

Testing Instructions for Keyboard

Not required.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/block-supports/border.php
❔ lib/block-supports/elements.php
❔ lib/block-supports/layout.php
❔ lib/block-supports/typography.php
❔ lib/blocks.php
❔ lib/class-wp-duotone-gutenberg.php
❔ lib/class-wp-theme-json-data-gutenberg.php
❔ lib/class-wp-theme-json-gutenberg.php
❔ lib/class-wp-theme-json-resolver-gutenberg.php
❔ lib/compat/wordpress-6.3/blocks.php
❔ lib/compat/wordpress-6.3/class-gutenberg-navigation-fallback.php
❔ lib/compat/wordpress-6.3/html-api/class-gutenberg-html-tag-processor-6-3.php
❔ lib/compat/wordpress-6.3/rest-api.php
❔ lib/compat/wordpress-6.3/script-loader.php
❔ lib/compat/wordpress-6.4/fonts/fonts.php
❔ lib/compat/wordpress-6.4/script-loader.php
❔ lib/experimental/block-hooks.php
❔ lib/experimental/blocks.php
❔ lib/experimental/class-wp-rest-customizer-nonces.php
❔ lib/experimental/fonts-api/bc-layer/class-wp-web-fonts.php
❔ lib/experimental/fonts-api/class-wp-fonts.php
❔ lib/experimental/fonts-api/fonts-api.php
❔ lib/experimental/fonts/font-library/class-wp-font-family.php
❔ lib/experimental/interactivity-api/class-wp-directive-context.php
❔ lib/experimental/interactivity-api/class-wp-directive-processor.php
❔ lib/experimental/interactivity-api/class-wp-interactivity-store.php
❔ lib/experimental/interactivity-api/directive-processing.php
❔ lib/experimental/kses.php
❔ lib/experimental/navigation-theme-opt-in.php
❔ phpunit/blocks/render-block-navigation-submenu-test.php
❔ phpunit/blocks/render-block-navigation-test.php
❔ phpunit/blocks/render-comment-template-test.php
❔ phpunit/blocks/render-post-template-test.php
❔ phpunit/class-block-context-test.php
❔ phpunit/class-block-library-navigation-link-test.php
❔ phpunit/class-gutenberg-navigation-fallback-gutenberg-test.php
❔ phpunit/class-gutenberg-rest-navigation-fallback-controller-test.php
❔ phpunit/class-phpunit-environment-setup-test.php
❔ phpunit/class-wp-theme-json-resolver-test.php
❔ phpunit/class-wp-theme-json-test.php
❔ phpunit/experimental/interactivity-api/directive-processing-test.php
❔ phpunit/experimental/interactivity-api/directives/wp-context-test.php
❔ phpunit/l10n-test.php
❔ phpunit/tests/fonts-api/base.php
❔ phpunit/tests/fonts-api/wpFonts/add.php
❔ phpunit/tests/fonts-api/wpFonts/addFontFamily.php
❔ phpunit/tests/fonts-api/wpFonts/doItem.php
❔ phpunit/tests/fonts-api/wpFonts/doItems.php
❔ phpunit/tests/fonts-api/wpFonts/registerProvider.php
❔ phpunit/tests/fonts-api/wpFontsResolver/registerFontsFromThemeJson.php
❔ phpunit/tests/fonts-api/wpRegisterFontProvider.php
❔ phpunit/tests/fonts/font-face/base.php
❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollection.php
❔ phpunit/tests/fonts/font-library/wpRestFontLibraryController/getFontCollection.php
❔ phpunit/tests/fonts/font-library/wpRestFontLibraryController/getFontCollections.php
❔ phpunit/tests/fonts/font-library/wpRestFontLibraryController/installFonts.php
❔ phpunit/tests/fonts/font-library/wpRestFontLibraryController/registerRoutes.php
❔ phpunit/tests/fonts/font-library/wpRestFontLibraryController/uninstallFonts.php

[jrfnl]

Hi @aristath Thanks for setting this up! Looking good. Just left a few remarks inline for you to consider.

[github-actions]

Flaky tests detected in b0b94b3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6168767791
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[dmsnell]

@aristath sorry I didn't catch this before it was merged.

for HTML API code this is pulled from Core, so changes need to happen first in Core and then be pulled into Gutenberg. second, the change from a while to a do probably introduced a vulnerability by using values that aren't checked. we should be careful to ensure our style preference changes don't impact the runtime behavior of code.

I'd like to revert the HTML API changes from here if it's okay with you and then work backwards from Core. can you create a patch/Trac ticket in Core to address the issues you have? in the meantime I'd like to revert so that we don't start maintaining two separate copies of this code.

[github-actions]

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: [Type] Automated Testing, [Type] Code Quality.

Read more about Type labels in Gutenberg.

[aristath]

@aristath sorry I didn't catch this before it was merged.

for HTML API code this is pulled from Core, so changes need to happen first in Core and then be pulled into Gutenberg. second, the change from a while to a do probably introduced a vulnerability by using values that aren't checked. we should be careful to ensure our style preference changes don't impact the runtime behavior of code.

I'd like to revert the HTML API changes from here if it's okay with you and then work backwards from Core. can you create a patch/Trac ticket in Core to address the issues you have? in the meantime I'd like to revert so that we don't start maintaining two separate copies of this code.

Of course, we can revert the changes to the HTML API in Gutenberg.
I think that WPCS 3.0 changes were already merged in Core, so this should have already been updated (if there are any commits remaining I'm sure they'll be merged soon).

[dmsnell]

I think that WPCS 3.0 changes were already merged in Core, so this should have already been updated (if there are any commits remaining I'm sure they'll be merged soon).

@aristath unfortunately not, and the two repos have different style preferences, so again, unfortunately, we now have divergent code in Core and Gutenberg and it's quite a mess. some of the changed introduced here have been applied to trunk in Core, but they haven't been applied to the 6.3 branch, meaning that when we pull the already-accepted and already-merged code from Core into Gutenberg, the 6.3 compat layer should have styles that WPCS doesn't like while eventually the 6.4 compat layer shouldn't.

currently I'm unable to revert without overriding the CI job because it's rejecting the change on style preferences, which is unfortunate, because it's enforcing that bug 🙃

I've mentioned you on #54481 where I'm trying to sort it all out, but admittedly, it's very confusing.