Site editor: fix start patterns store selector #58813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @bgardner. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Feb 8, 2024
|
Size Change: -8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/fix-start-patterns-selector
branch
from
b16def8
to
d5bf277
Compare
ellatrix
added
Backported to WP Core
aristath
added a commit
that referenced
this pull request
Feb 13, 2024
* trunk: (273 commits) Remove preffered style variations legacy support (#58930) Style theme variations: add property extraction and merge utils (#58803) Migrate `change-detection` to Playwright (#58767) Update Changelog for 17.6.6 Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915) Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943) Try double enter for details block. (#58903) Template revisions API: move from experimental to compat/6.4 (#58920) Editor: Remove inline toolbar preference (#58945) Clean up link control CSS. (#58934) Font Library: Show error message when no fonts found to install (#58914) Block Bindings: lock editing of blocks by default (#58787) Editor: Remove the 'all' rendering mode (#58935) Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189) Close link preview if collapsed selection when creating link (#58896) Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900) Upgrade Floating UI packages, fix nested iframe positioning bug (#58932) Site editor: fix start patterns store selector (#58813) Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792) Documentation: Clarify the performance reference commit and how to pick it (#58927) ...
youknowriad
added a commit
that referenced
this pull request
Feb 13, 2024
Unlinked contributors: bgardner. Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
|
I just cherry-picked this PR to the backports/beta1 branch to get it included in the next release: 924b0f1 |
youknowriad
removed
the
Backport to WP Beta/RC
youknowriad
added a commit
that referenced
this pull request
Feb 13, 2024
Unlinked contributors: bgardner. Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
youknowriad
added a commit
that referenced
this pull request
Feb 13, 2024
Unlinked contributors: bgardner. Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
creativecoder
added
the
[Feature] Patterns
|
Note that as part of curating the Gutenberg 17.8 changelog, I added the label [Feature] Patterns to this PR to better categorize it. Please let me know if there is a different label that would be a better fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The problem is that we're using the
__experimentalBlockPatternsblock editor setting, which was justselect( core ).getBlockPatterns()forwarded. Since #57999 this setting is no longer used to pass theme patterns to the block editor store. We should be usingselect( core ).getBlockPatterns()directly.Why?
Fixes #58223.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast