Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template revisions API: move from experimental to compat/6.4 #58920

Merged
merged 2 commits into from Feb 12, 2024

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Feb 12, 2024

What?

Reverting #51774 by moving the templates revisions experimental code into compat/6.4

Original PR:

Note

Doesn't require a backport

Why?

The original PR was slated for Wordpress 6.3, but didn't make it because of an upstream issue. See #45215 (comment)

The upstream fix was made in WordPress 6.4. See: WordPress/wordpress-develop@1f51e1f

Also cc @georgeh

Testing Instructions

Check for no regressions from trunk.

Check that you see a templates revision item when editing a template in the site editor (after 3 changes)

Screenshot 2024-02-12 at 2 54 43 pm

Using WordPress 6.4 + this branch, ensure that you can do the same.

Reverting #51774 by moving the experimental code into compat/6.4

The changes to the templates controller were made in WordPress 6.4. See: WordPress/wordpress-develop@1f51e1f
@ramonjd ramonjd added Backwards Compatibility Issues or PRs that impact backwards compatability [Type] Code Quality Issues or PRs that relate to code quality labels Feb 12, 2024
@ramonjd ramonjd self-assigned this Feb 12, 2024
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.4/rest-api.php
❔ lib/experimental/rest-api.php
❔ lib/load.php
❔ lib/compat/wordpress-6.4/class-gutenberg-rest-templates-controller-6-4.php

Copy link

github-actions bot commented Feb 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@draganescu draganescu merged commit cf18b3b into trunk Feb 12, 2024
57 checks passed
@draganescu draganescu deleted the refactor/6-4-compat-templates-controller branch February 12, 2024 17:15
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 12, 2024
@ramonjd
Copy link
Member Author

ramonjd commented Feb 12, 2024

Thanks for merging!

aristath added a commit that referenced this pull request Feb 13, 2024
* trunk: (273 commits)
  Remove preffered style variations legacy support (#58930)
  Style theme variations: add property extraction and merge utils (#58803)
  Migrate `change-detection` to Playwright (#58767)
  Update Changelog for 17.6.6
  Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915)
  Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943)
  Try double enter for details block. (#58903)
  Template revisions API: move from experimental to compat/6.4 (#58920)
  Editor: Remove inline toolbar preference (#58945)
  Clean up link control CSS. (#58934)
  Font Library: Show error message when no fonts found to install (#58914)
  Block Bindings: lock editing of blocks by default (#58787)
  Editor: Remove the 'all' rendering mode (#58935)
  Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189)
  Close link preview if collapsed selection when creating link (#58896)
  Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900)
  Upgrade Floating UI packages, fix nested iframe positioning bug (#58932)
  Site editor: fix start patterns store selector (#58813)
  Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792)
  Documentation: Clarify the performance reference commit and how to pick it (#58927)
  ...
@creativecoder creativecoder added the REST API Interaction Related to REST API label Feb 21, 2024
@creativecoder
Copy link
Contributor

Note that as part of curating the Gutenberg 17.8 changelog, I added the label REST API Interaction to this PR to better categorize it.

Please let me know if there is a different label that would be a better fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability REST API Interaction Related to REST API [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants