Font Library: Show error message when no fonts found to install #58914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
matiasbenedetto
approved these changes
Feb 12, 2024
t-hamano
added
the
Backport to WP Beta/RC
|
I'm giving it the backport label because the font library is a feature that will ship for the first time in WP6.5, and I think it's worth backporting this fix. |
aristath
added a commit
that referenced
this pull request
Feb 13, 2024
* trunk: (273 commits) Remove preffered style variations legacy support (#58930) Style theme variations: add property extraction and merge utils (#58803) Migrate `change-detection` to Playwright (#58767) Update Changelog for 17.6.6 Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915) Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943) Try double enter for details block. (#58903) Template revisions API: move from experimental to compat/6.4 (#58920) Editor: Remove inline toolbar preference (#58945) Clean up link control CSS. (#58934) Font Library: Show error message when no fonts found to install (#58914) Block Bindings: lock editing of blocks by default (#58787) Editor: Remove the 'all' rendering mode (#58935) Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189) Close link preview if collapsed selection when creating link (#58896) Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900) Upgrade Floating UI packages, fix nested iframe positioning bug (#58932) Site editor: fix start patterns store selector (#58813) Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792) Documentation: Clarify the performance reference commit and how to pick it (#58927) ...
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: okmttdhr <okat@git.wordpress.org>
|
I just cherry-picked this PR to the backports/beta1 branch to get it included in the next release: 5ccaa81 |
youknowriad
removed
the
Backport to WP Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: okmttdhr <okat@git.wordpress.org>
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: okmttdhr <okat@git.wordpress.org>
matiasbenedetto
added
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58874
What?
This PR displays an error message when a file with an extension that is not allowed as a font is uploaded.
Why?
In the current implementation, if there are no fonts available for installation, the
isUploadingstate will remaintrue, and the user will not know what is happening.How?
If there are no valid fonts, an error message will be displayed.
At the same time, I removed unnecessary
useEffectsfrom the context. This is part of #58428. This will also fix the issue where the error message cannot be removed.af6c94c88500499ec6f8cbb1ee6a9c4a.mp4
Testing Instructions
Screenshots or screencast